From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6AD9F1FF13C for ; Thu, 30 Apr 2026 17:07:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48AD8E86B; Thu, 30 Apr 2026 17:07:14 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 05/10] www: don't claim that all active writers are gc mode conflicts Date: Thu, 30 Apr 2026 17:05:46 +0200 Message-ID: <20260430150607.330413-9-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260430150607.330413-1-r.obkircher@proxmox.com> References: <20260430150607.330413-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777561501409 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V5UFB7LOGA2573XBZASNPVKOR456EHXB X-Message-ID-Hash: V5UFB7LOGA2573XBZASNPVKOR456EHXB X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Tracking the precise number of conflicts doesn't seem worth it, so continue displaying the writer count with a different label. Signed-off-by: Robert Obkircher --- www/Utils.js | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index f5c032ee2..a9239b005 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -828,10 +828,17 @@ Ext.define('PBS.Utils', { if (conflictingTasks > 0) { extra += '| '; - extra += Ext.String.format( - gettext('{0} conflicting tasks still active.'), - conflictingTasks, - ); + if (type === 'garbage-collection') { + extra += Ext.String.format( + gettext('{0} active writers.'), + conflictingTasks, + ); + } else { + extra += Ext.String.format( + gettext('{0} conflicting tasks still active.'), + conflictingTasks, + ); + } } else { extra += ''; } -- 2.47.3