From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8550E1FF13C for ; Thu, 30 Apr 2026 14:50:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68ADC797B; Thu, 30 Apr 2026 14:50:07 +0200 (CEST) From: Christoph Heiss To: pdm-devel@lists.proxmox.com Subject: [PATCH installer v4 25/40] install: iso env: use JSON boolean literals for product config Date: Thu, 30 Apr 2026 14:46:54 +0200 Message-ID: <20260430124712.1614305-26-c.heiss@proxmox.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430124712.1614305-1-c.heiss@proxmox.com> References: <20260430124712.1614305-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777553273274 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JPPNSQT4XPPVWXLF3O66GUZHFHROXDHF X-Message-ID-Hash: JPPNSQT4XPPVWXLF3O66GUZHFHROXDHF X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For Perl, they act the same as the previous `0`/`1` literals, but create proper `true`/`false` literals when serializing to JSON. This makes the final JSON more consistent and easier to parse. No functional changes. Reviewed-by: Lukas Wagner Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * new patch Proxmox/Install/ISOEnv.pm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Proxmox/Install/ISOEnv.pm b/Proxmox/Install/ISOEnv.pm index a76077b..d2853fe 100644 --- a/Proxmox/Install/ISOEnv.pm +++ b/Proxmox/Install/ISOEnv.pm @@ -16,26 +16,26 @@ my $product_cfg = { pve => { fullname => 'Proxmox VE', port => '8006', - enable_btrfs => 1, - bridged_network => 1, + enable_btrfs => JSON::true, + bridged_network => JSON::true, }, pmg => { fullname => 'Proxmox Mail Gateway', port => '8006', - enable_btrfs => 0, - bridged_network => 0, + enable_btrfs => JSON::false, + bridged_network => JSON::false, }, pbs => { fullname => 'Proxmox Backup Server', port => '8007', - enable_btrfs => 0, - bridged_network => 0, + enable_btrfs => JSON::false, + bridged_network => JSON::false, }, pdm => { fullname => 'Proxmox Datacenter Manager', port => '8443', # TODO: confirm - enable_btrfs => 0, - bridged_network => 0, + enable_btrfs => JSON::false, + bridged_network => JSON::false, }, }; -- 2.53.0