[PATCH proxmox-backup 1/1] fix #6691: allow search by comment in datastore.

[Erik Fastermann <e.fastermann@proxmox.com>]

Enable search by the comment field in the datastore content.

Also includes multiple small bug fixes:

- Display items again when searching by a non existing value and
  clearing the search bar.
- Correctly disable the remove box and tooltip for namespaces.
- Correctly disable the browse box and tooltip for the root namespace.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6691
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
 www/datastore/Content.js | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 1ec07505d..29b27eced 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -941,6 +941,10 @@ Ext.define('PBS.DataStoreContent', {
                 return true;
             }
 
+            if (item.data.comment && item.data.comment.indexOf(value) !== -1) {
+                return true;
+            }
+
             return false;
         },
 
@@ -963,7 +967,6 @@ Ext.define('PBS.DataStoreContent', {
             // we do it a little bit later for the error mask to work
             setTimeout(function () {
                 store.clearFilter();
-                store.getRoot().collapseChildren(true);
 
                 store.beginUpdate();
                 store.getRoot().cascadeBy({
@@ -1150,14 +1153,18 @@ Ext.define('PBS.DataStoreContent', {
                         return Ext.String.format(gettext("Move namespace '{0}'"), v);
                     },
                     getClass: (v, m, { data }) => {
-                        if (data.ty === 'group') { return 'fa fa-arrows'; }
+                        if (data.ty === 'group') {
+                            return 'fa fa-arrows';
+                        }
                         if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) {
                             return 'fa fa-arrows';
                         }
                         return 'pmx-hidden';
                     },
                     isActionDisabled: (v, r, c, i, { data }) => {
-                        if (data.ty === 'group') { return false; }
+                        if (data.ty === 'group') {
+                            return false;
+                        }
                         if (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) {
                             return false;
                         }
@@ -1210,7 +1217,12 @@ Ext.define('PBS.DataStoreContent', {
                         data.ty === 'dir'
                             ? 'fa critical fa-trash-o'
                             : 'pmx-hidden',
-                    isActionDisabled: (v, r, c, i, { data }) => false,
+                    isActionDisabled: (v, r, c, i, { data }) =>
+                        !(
+                            (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) ||
+                            data.ty === 'group' ||
+                            data.ty === 'dir'
+                        ),
                 },
                 {
                     handler: 'downloadFile',
@@ -1235,12 +1247,14 @@ Ext.define('PBS.DataStoreContent', {
                         return 'pmx-hidden';
                     },
                     isActionDisabled: (v, r, c, i, { data }) =>
-                        !(
+                        (!(
                             data.ty === 'file' &&
                             (data.filename.endsWith('.pxar.didx') ||
                                 data.filename.endsWith('.mpxar.didx')) &&
                             data['crypt-mode'] < 3
-                        ) && data.ty !== 'ns',
+                        ) &&
+                            data.ty !== 'ns') ||
+                        data.root,
                 },
             ],
         },
@@ -1486,7 +1500,7 @@ Ext.define('PBS.DataStoreContent', {
         {
             xtype: 'textfield',
             reference: 'searchbox',
-            emptyText: gettext('group, date or owner'),
+            emptyText: gettext('group, date, owner or comment'),
             triggers: {
                 clear: {
                     cls: 'pmx-clear-trigger',
-- 
2.47.3