From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v3] ui: encryption keys: show error text instead of empty popup in API alerts
Date: Wed, 29 Apr 2026 12:11:06 +0200 [thread overview]
Message-ID: <20260429101139.163532-1-a.bied-charreton@proxmox.com> (raw)
The errors returned by the encryption-keys and tape-encryption-keys
endpoints are not plain strings, so the alerts displayed on API2 errors
like failed permission checks end up being empty and therefore not very
helpful.
Extract the error messages to display them correctly in alerts.
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
Sorry forgot to fold the htmlStatus change into the commit..
www/config/EncryptionKeysView.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js
index 0f9367c7..db2fd641 100644
--- a/www/config/EncryptionKeysView.js
+++ b/www/config/EncryptionKeysView.js
@@ -168,7 +168,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
});
}
} catch (error) {
- Ext.Msg.alert(gettext('Error'), error);
+ Ext.Msg.alert(gettext('Error'), error.htmlStatus || gettext('Unknown error'));
}
try {
@@ -181,7 +181,7 @@ Ext.define('PBS.config.EncryptionKeysView', {
});
}
} catch (error) {
- Ext.Msg.alert(gettext('Error'), error);
+ Ext.Msg.alert(gettext('Error'), error.htmlStatus || gettext('Unknown error'));
}
let store = view.getStore().rstore;
--
2.47.3
next reply other threads:[~2026-04-29 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 10:11 Arthur Bied-Charreton [this message]
2026-04-29 16:23 ` applied: [PATCH proxmox-backup v3] ui: encryption keys: show error text instead of empty popup in API alerts Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429101139.163532-1-a.bied-charreton@proxmox.com \
--to=a.bied-charreton@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.