From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6F6201FF13A for ; Wed, 29 Apr 2026 12:03:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3194627BDE; Wed, 29 Apr 2026 12:03:04 +0200 (CEST) From: Arthur Bied-Charreton To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2] ui: encryption keys: show error text instead of empty popup in API alerts Date: Wed, 29 Apr 2026 12:02:37 +0200 Message-ID: <20260429100257.155092-1-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.128 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: Z3SFUQMKLRUPYYW4SJMMIEALTK3O3C2L X-Message-ID-Hash: Z3SFUQMKLRUPYYW4SJMMIEALTK3O3C2L X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The errors returned by the encryption-keys and tape-encryption-keys endpoints are not plain strings, so the alerts displayed on API2 errors like failed permission checks end up being empty and therefore not very helpful. Extract the error messages to display them correctly in alerts. Signed-off-by: Arthur Bied-Charreton --- www/config/EncryptionKeysView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js index 0f9367c7..bb327814 100644 --- a/www/config/EncryptionKeysView.js +++ b/www/config/EncryptionKeysView.js @@ -168,7 +168,7 @@ Ext.define('PBS.config.EncryptionKeysView', { }); } } catch (error) { - Ext.Msg.alert(gettext('Error'), error); + Ext.Msg.alert(gettext('Error'), error.result?.message || gettext('Unknown error')); } try { @@ -181,7 +181,7 @@ Ext.define('PBS.config.EncryptionKeysView', { }); } } catch (error) { - Ext.Msg.alert(gettext('Error'), error); + Ext.Msg.alert(gettext('Error'), error.result?.message || gettext('Unknown error')); } let store = view.getStore().rstore; -- 2.47.3