Re: [PATCH proxmox-backup] EncryptionKeysView: Fix API2 error alert messages

Thomas Lamprecht
2026-04-29T09:57:48Z

Code change is fine, but the metadata needs polish before this can go in,
it's only the subject that should improve though:

* Subject prefix should be the product area, not a JS class name. For
this view we use `ui: encryption keys: ...`, see e.g. ffe55e23e,
67235b5fb. Lowercase, two-level path, separated by colons.

* Lowercase imperative after the colon: "Fix" -> "fix".

* The text after the prefix should describe what visibly changes for
the user, not the mechanism. "Fix API2 error alert messages" hides
the symptom; something like

ui: encryption keys: show actual error text in API alerts instead of empty popup

reads on its own in `git log` and tells a future git bisect(or)
and changelog writers what this really changed without having
to look at the full commit message or even the code changes.

See the proxmox commit-message conventions on the dev wiki and
`git log --oneline www/` for examples in this tree.