From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6DD241FF146 for ; Tue, 28 Apr 2026 14:26:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 495D411F39; Tue, 28 Apr 2026 14:26:54 +0200 (CEST) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 1/3] datastore: read ctime from didx header instead of using current time Date: Tue, 28 Apr 2026 14:21:31 +0200 Message-ID: <20260428122544.19899-2-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260428122544.19899-1-r.obkircher@proxmox.com> References: <20260428122544.19899-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777379084288 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BQU5LW4JJ2SMPYNH5OFJR4NAMNO6ZZBD X-Message-ID-Hash: BQU5LW4JJ2SMPYNH5OFJR4NAMNO6ZZBD X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: It looks like this was accidentally changed during a refactor in 2020. The ctime field is public, so it is not obvious whether anyone depends on the broken behavior. The index_ctime accessor only seems to be used by inspect_file in proxmox_backup_debug. Fixes: 6a7be83efe ("avoid chrono dependency, depend on proxmox 0.3.8") Signed-off-by: Robert Obkircher --- pbs-datastore/src/dynamic_index.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pbs-datastore/src/dynamic_index.rs b/pbs-datastore/src/dynamic_index.rs index e1ca0eae..288f38b5 100644 --- a/pbs-datastore/src/dynamic_index.rs +++ b/pbs-datastore/src/dynamic_index.rs @@ -119,8 +119,6 @@ impl DynamicIndexReader { bail!("got unknown magic number"); } - let ctime = proxmox_time::epoch_i64(); - let index_size = stat.st_size as usize - header_size; let index_count = index_size / 40; if index_count * 40 != index_size { @@ -141,7 +139,7 @@ impl DynamicIndexReader { _file: file, size, index, - ctime, + ctime: header.ctime, uuid: header.uuid, index_csum: header.index_csum, }) -- 2.47.3