From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 37D2C1FF133 for ; Mon, 27 Apr 2026 18:03:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 056B722B84; Mon, 27 Apr 2026 18:03:27 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server] fix #3662: tpm: use QSD to give swtpm access to iscsi-based volumes Date: Mon, 27 Apr 2026 18:01:08 +0200 Message-ID: <20260427160205.56965-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777305633214 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: P23ZLERBWAONNTSXIH6KXJ2B7HSMMDKA X-Message-ID-Hash: P23ZLERBWAONNTSXIH6KXJ2B7HSMMDKA X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The iSCSIDirect and ZFS-over-iSCSI plugins do not implement map_volume() and only provide an iscsi protocol path. Use QSD to make such volumes accessible to swtpm. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/Drive.pm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm index 625ed80c..b80b7dbb 100644 --- a/src/PVE/QemuServer/Drive.pm +++ b/src/PVE/QemuServer/Drive.pm @@ -1159,8 +1159,15 @@ sub drive_uses_qsd_fuse { if ($drive->{interface} eq 'tpmstate') { my ($storeid) = PVE::Storage::parse_volume_id($drive->{file}, 1); + return if !$storeid; # not managed by the PVE storage layer + + # The iSCSIDirect and ZFS-over-iSCSI plugins do not implement map_volume() and only provide + # an iscsi protocol path. Use QSD to make such volumes accessible to swtpm. + my $path = PVE::Storage::path($storecfg, $drive->{file}); + return 1 if $path =~ m!^iscsi://!; + my $format = checked_volume_format($storecfg, $drive->{file}); - return $storeid && $format ne 'raw'; + return $format ne 'raw'; } return; -- 2.47.3