From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C79EC1FF133 for ; Mon, 27 Apr 2026 15:00:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9EC701D815; Mon, 27 Apr 2026 15:00:10 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] client: show full error context in single line on upload errors Date: Mon, 27 Apr 2026 14:59:55 +0200 Message-ID: <20260427125955.653377-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777294711727 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: P2ZNAPQ4WTJO2M55JCMIWHW3OPFTER65 X-Message-ID-Hash: P2ZNAPQ4WTJO2M55JCMIWHW3OPFTER65 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since commit 07cb3e7f7 ("client: pxar: optionally split metadata and payload streams") there are possibly multiple upload streams (data and metadata archive), errors for each propagated accordingly. Since this reformatted the error without explicitly including the context, the resulting error messages are lacking crucial information. Reformat the error with full context. Fixes: 07cb3e7f7 ("client: pxar: optionally split metadata and payload streams") Signed-off-by: Christian Ebner --- proxmox-backup-client/src/main.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs index 1c1ad9a0f..a1533b79b 100644 --- a/proxmox-backup-client/src/main.rs +++ b/proxmox-backup-client/src/main.rs @@ -322,10 +322,10 @@ async fn backup_directory>( match futures::join!(stats, payload_stats) { (Ok(stats), Ok(payload_stats)) => Ok((stats, Some(payload_stats))), - (Err(err), Ok(_)) => Err(format_err!("upload failed: {err}")), - (Ok(_), Err(err)) => Err(format_err!("upload failed: {err}")), + (Err(err), Ok(_)) => Err(format_err!("upload failed: {err:#}")), + (Ok(_), Err(err)) => Err(format_err!("upload failed: {err:#}")), (Err(err), Err(payload_err)) => { - Err(format_err!("upload failed: {err} - {payload_err}")) + Err(format_err!("upload failed: {err:#} - {payload_err:#}")) } } } else { -- 2.47.3