all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 3/3] qm: unlock: add reminder to switch to remove_lock() helper for a major release
Date: Mon, 27 Apr 2026 13:22:45 +0200	[thread overview]
Message-ID: <20260427112255.369695-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260427112255.369695-1-f.ebner@proxmox.com>

For containers, the remove_lock() helper from the AbstractConfig
module is already used. That method dies if no lock was found, while
the current implementation for 'qm unlock' returns success. To avoid
tripping up tooling, delay aligning the behavior between 'qm' and
'pct' to a future major release.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/CLI/qm.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm
index e64449d7..bc8a086c 100755
--- a/src/PVE/CLI/qm.pm
+++ b/src/PVE/CLI/qm.pm
@@ -391,6 +391,9 @@ __PACKAGE__->register_method({
 
         my $vmid = $param->{vmid};
 
+        # FIXME: MAJOR VERSION: switch to PVE::QemuConfig->remove_lock() to align behavior with
+        # containers. Note that remove_lock() will die when no lock is found, so that is a change in
+        # behavior.
         PVE::QemuConfig->lock_config(
             $vmid,
             sub {
-- 
2.47.3





      parent reply	other threads:[~2026-04-27 11:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 11:22 [PATCH-SERIES container/qemu-server 0/3] pct/qm: unlock: log that operation happened to syslog Fiona Ebner
2026-04-27 11:22 ` [PATCH container 1/3] pct: " Fiona Ebner
2026-04-27 11:22 ` [PATCH qemu-server 2/3] qm: " Fiona Ebner
2026-04-27 11:22 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260427112255.369695-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal