Re: applied: [PATCH proxmox-backup] sync: pull: use LogLineSender in d SyncSourceReader

Christian Ebner
2026-04-27T06:37:14Z

On 4/26/26 11:38 PM, Thomas Lamprecht wrote:
> Am 24.04.26 um 15:35 schrieb Dominik Csapak:
>> otherwise some log messages are not rendered with the correct prefix
>> when using multiple worker threads.
>>
>> For example:
>>
>> Snapshot ct/122/2026-04-24T12:56:17Z: got backup log file client.log.blob
>>
>> vs
>>
>> [ct/122]: Snapshot ct/122/2026-04-24T13:00:02Z: got backup log file client.log.blob
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> there may be other places where we don't use the LogLineSender here,
>> but could not find any on first glance.
>>
> I know you were a bit earlier, but I chose Chris variant as the rest
> of his fixes of his series was a bit more crucial [0], might be still
> great if one of you could cross-check to ensure nothing was missed.
>
> Marking this still as applied here because if effectively should be
> addressed, and thus mail filters used mark it as obsolete. Should I have
> missed something here then it would needs a new submission that was
> rebased on master anyway
>
> [0]: https://lore.proxmox.com/pbs-devel/20260425140927.928214-3-c.ebner@proxmox.com/

Double checked: Dominiks patch did also cover the 'skip because vanished
since start of sync' log message, which was not covered by my patches.