all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v8 11/13] ui: add move group action
Date: Wed, 22 Apr 2026 15:39:49 +0200	[thread overview]
Message-ID: <20260422133951.192862-12-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260422133951.192862-1-h.laimer@proxmox.com>

Add a "Move" action to the backup group context menu and action
column. Opens a dialog where the user selects a target namespace,
then submits a POST to the move-group API endpoint.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 www/Makefile             |  1 +
 www/datastore/Content.js | 47 ++++++++++++++++++++++++++
 www/window/GroupMove.js  | 71 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 119 insertions(+)
 create mode 100644 www/window/GroupMove.js

diff --git a/www/Makefile b/www/Makefile
index 5a60e47e..06441c02 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -76,6 +76,7 @@ JSSRC=							\
 	config/PruneAndGC.js				\
 	window/ACLEdit.js				\
 	window/BackupGroupChangeOwner.js		\
+	window/GroupMove.js				\
 	window/CreateDirectory.js			\
 	window/DataStoreEdit.js				\
 	window/NamespaceEdit.js				\
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index dfb7787c..548f5670 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -668,6 +668,27 @@ Ext.define('PBS.DataStoreContent', {
             });
         },
 
+        moveGroup: function (data) {
+            let me = this;
+            let view = me.getView();
+            let group = `${data.backup_type}/${data.backup_id}`;
+            Ext.create('PBS.window.GroupMove', {
+                datastore: view.datastore,
+                namespace: view.namespace,
+                backupType: data.backup_type,
+                backupId: data.backup_id,
+                group,
+                taskDone: () => me.reload(),
+            }).show();
+        },
+
+        onMove: function (table, rI, cI, item, e, { data }) {
+            let me = this;
+            if (data.ty === 'group') {
+                me.moveGroup(data);
+            }
+        },
+
         forgetGroup: function (data) {
             let me = this;
             let view = me.getView();
@@ -972,6 +993,7 @@ Ext.define('PBS.DataStoreContent', {
                     onVerify: createControllerCallback('onVerify'),
                     onChangeOwner: createControllerCallback('onChangeOwner'),
                     onPrune: createControllerCallback('onPrune'),
+                    onMove: createControllerCallback('onMove'),
                     onForget: createControllerCallback('onForget'),
                 });
             } else if (record.data.ty === 'dir') {
@@ -1086,6 +1108,20 @@ Ext.define('PBS.DataStoreContent', {
                             : 'pmx-hidden',
                     isActionDisabled: (v, r, c, i, rec) => !!rec.data.leaf,
                 },
+                {
+                    handler: 'onMove',
+                    getTip: (v, m, { data }) => {
+                        if (data.ty === 'group') {
+                            return Ext.String.format(gettext("Move group '{0}'"), v);
+                        }
+                        return '';
+                    },
+                    getClass: (v, m, { data }) => {
+                        if (data.ty === 'group') { return 'fa fa-arrows'; }
+                        return 'pmx-hidden';
+                    },
+                    isActionDisabled: (v, r, c, i, { data }) => data.ty !== 'group',
+                },
                 {
                     handler: 'onChangeOwner',
                     getClass: (v, m, { data }) =>
@@ -1438,6 +1474,7 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
     onVerify: undefined,
     onChangeOwner: undefined,
     onPrune: undefined,
+    onMove: undefined,
     onForget: undefined,
 
     items: [
@@ -1461,6 +1498,16 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
                 hidden: '{!onVerify}',
             },
         },
+        {
+            text: gettext('Move'),
+            iconCls: 'fa fa-arrows',
+            handler: function () {
+                this.up('menu').onMove();
+            },
+            cbind: {
+                hidden: '{!onMove}',
+            },
+        },
         {
             text: gettext('Change owner'),
             iconCls: 'fa fa-user',
diff --git a/www/window/GroupMove.js b/www/window/GroupMove.js
new file mode 100644
index 00000000..6fa5588a
--- /dev/null
+++ b/www/window/GroupMove.js
@@ -0,0 +1,71 @@
+Ext.define('PBS.window.GroupMove', {
+    extend: 'Proxmox.window.Edit',
+    alias: 'widget.pbsGroupMove',
+    mixins: ['Proxmox.Mixin.CBind'],
+
+    onlineHelp: 'storage-move-namespaces-groups',
+
+    isCreate: true,
+    submitText: gettext('Move'),
+    showTaskViewer: true,
+
+    cbind: {
+        url: '/api2/extjs/admin/datastore/{datastore}/move-group',
+        title: (get) => Ext.String.format(gettext("Move Backup Group '{0}'"), get('group')),
+    },
+    method: 'POST',
+
+    width: 400,
+    fieldDefaults: {
+        labelWidth: 120,
+    },
+
+    items: {
+        xtype: 'inputpanel',
+        onGetValues: function (values) {
+            let win = this.up('window');
+            let result = {
+                'backup-type': win.backupType,
+                'backup-id': win.backupId,
+                'target-ns': values['target-ns'] || '',
+            };
+            if (win.namespace && win.namespace !== '') {
+                result.ns = win.namespace;
+            }
+            if (values['merge-group'] !== undefined) {
+                result['merge-group'] = values['merge-group'];
+            }
+            return result;
+        },
+        items: [
+            {
+                xtype: 'displayfield',
+                fieldLabel: gettext('Group'),
+                cbind: {
+                    value: '{group}',
+                },
+            },
+            {
+                xtype: 'pbsNamespaceSelector',
+                name: 'target-ns',
+                fieldLabel: gettext('Target Namespace'),
+                allowBlank: true,
+                cbind: {
+                    datastore: '{datastore}',
+                },
+            },
+        ],
+        advancedItems: [
+            {
+                xtype: 'proxmoxcheckbox',
+                name: 'merge-group',
+                fieldLabel: gettext('Merge Group'),
+                checked: true,
+                autoEl: {
+                    tag: 'div',
+                    'data-qtip': gettext('If a group with the same name already exists in the target namespace, merge snapshots into it. Requires matching ownership and non-overlapping snapshot times.'),
+                },
+            },
+        ],
+    },
+});
-- 
2.47.3





  parent reply	other threads:[~2026-04-22 13:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 13:39 [PATCH proxmox-backup v8 00/13] fixes #6195: add support for moving groups and namespaces Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 01/13] ui: show empty groups Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 02/13] datastore: lift check_namespace_depth_limit to pbs-datastore Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 03/13] datastore: have BackupGroup::destroy consume the group lock Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 04/13] datastore: split remove_namespace into flat and recursive variants Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 05/13] datastore: add move journal for coordinating with gc phase 1 Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 06/13] datastore: add move-group Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 07/13] datastore: add move-namespace Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 08/13] docs: add section on moving namespaces and groups Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 09/13] api: add POST endpoint for move-group Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 10/13] api: add POST endpoint for move-namespace Hannes Laimer
2026-04-22 13:39 ` Hannes Laimer [this message]
2026-04-23 13:35   ` [PATCH proxmox-backup v8 11/13] ui: add move group action Michael Köppl
2026-04-23 13:47     ` Hannes Laimer
2026-04-22 13:39 ` [PATCH proxmox-backup v8 12/13] ui: add move namespace action Hannes Laimer
2026-04-23 14:49   ` Michael Köppl
2026-04-22 13:39 ` [PATCH proxmox-backup v8 13/13] cli: add move-namespace and move-group commands Hannes Laimer
2026-04-23 16:29 ` [PATCH proxmox-backup v8 00/13] fixes #6195: add support for moving groups and namespaces Michael Köppl
2026-04-23 22:38 ` applied: " Thomas Lamprecht
2026-04-24  8:31   ` Fabian Grünbichler
2026-04-24  8:43     ` Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422133951.192862-12-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal