all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-acme] fix: acme: add missing `_json_decode` function
Date: Tue, 21 Apr 2026 14:12:12 +0200	[thread overview]
Message-ID: <20260421121212.218008-1-s.shaji@proxmox.com> (raw)

While placing the ACME certificate order using the Active24 plugin,
the request was failing [0]. This was because, `_json_decode` function
was referenced inside the dns_active24.sh file but was never defined
in the `proxmox-acme` script.To fix it, the missing function was added
by referencing the implementation from the acme.sh [1] script.

- [0] https://forum.proxmox.com/threads/acme-active24-dns-plugin-error-json_decode-command-not-found.182899/
- [1] https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L912

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---

 **note**: I couldn't test the changes as i don't have Active24 credentials.
 
 src/proxmox-acme | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/proxmox-acme b/src/proxmox-acme
index 9eea590..499d533 100644
--- a/src/proxmox-acme
+++ b/src/proxmox-acme
@@ -913,6 +913,14 @@ _source_plugin_config() {
   return 0
 }
 
+# from: http:\/\/ to http://
+_json_decode() {
+  _j_str="$(sed 's#\\/#/#g')"
+  _debug3 "_json_decode"
+  _debug3 "_j_str" "$_j_str"
+  echo "$_j_str"
+}
+
 # Proxmox implementation to inject the DNSAPI variables
 _load_plugin_config() {
     while IFS= read -r line; do
-- 
2.47.3





                 reply	other threads:[~2026-04-21 12:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260421121212.218008-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal