all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v2 1/3] pbs-api-types: add gc-on-unmount flag for removable datastores
Date: Mon, 20 Apr 2026 09:42:55 +0200	[thread overview]
Message-ID: <20260420074257.9492-2-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260420074257.9492-1-h.laimer@proxmox.com>

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 pbs-api-types/src/datastore.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index 9e85affc..098d2b7c 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -452,6 +452,11 @@ pub const COUNTER_RESET_SCHEDULE_SCHEMA: Schema =
             optional: true,
             schema: GC_SCHEDULE_SCHEMA,
         },
+        "gc-on-unmount": {
+            description: "Run garbage collection before unmounting a removable datastore.",
+            optional: true,
+            type: bool,
+        },
         "prune-schedule": {
             optional: true,
             schema: PRUNE_SCHEDULE_SCHEMA,
@@ -510,6 +515,9 @@ pub struct DataStoreConfig {
     #[serde(skip_serializing_if = "Option::is_none")]
     pub gc_schedule: Option<String>,
 
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub gc_on_unmount: Option<bool>,
+
     #[serde(skip_serializing_if = "Option::is_none")]
     pub prune_schedule: Option<String>,
 
@@ -586,6 +594,7 @@ impl DataStoreConfig {
             path,
             comment: None,
             gc_schedule: None,
+            gc_on_unmount: None,
             prune_schedule: None,
             keep: Default::default(),
             verify_new: None,
-- 
2.47.3





  reply	other threads:[~2026-04-20  7:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20  7:42 [PATCH proxmox{,-backup} v2 0/3] fixes #7465: add gc-on-unmount flag Hannes Laimer
2026-04-20  7:42 ` Hannes Laimer [this message]
2026-04-21 22:17   ` applied: [PATCH proxmox v2 1/3] pbs-api-types: add gc-on-unmount flag for removable datastores Thomas Lamprecht
2026-04-20  7:42 ` [PATCH proxmox-backup v2 2/3] api: datastore: add option to run garbage collection before unmount Hannes Laimer
2026-04-20  8:32   ` Shannon Sterz
2026-04-20  8:45     ` Hannes Laimer
2026-04-20  8:52       ` Shannon Sterz
2026-04-20  7:42 ` [PATCH proxmox-backup v2 3/3] ui: datastore: expose gc-on-unmount setting Hannes Laimer
2026-04-21 11:34 ` [PATCH proxmox{,-backup} v2 0/3] fixes #7465: add gc-on-unmount flag Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420074257.9492-2-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal