From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DA3701FF13E for ; Fri, 17 Apr 2026 14:28:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 96FA1CDB; Fri, 17 Apr 2026 14:28:09 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 7/7] test: ha-tester: use colorized diff for unexpected test log outputs Date: Fri, 17 Apr 2026 14:27:22 +0200 Message-ID: <20260417122728.330123-8-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260417122728.330123-1-d.kral@proxmox.com> References: <20260417122728.330123-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776428771832 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HTI3BLTGMWZZHBBWEVKJ4DJL5H3TXUEK X-Message-ID-Hash: HTI3BLTGMWZZHBBWEVKJ4DJL5H3TXUEK X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Make the diffs for failed integration tests use color, which makes it a little easier to read on terminals with color support. diff's --color defaults to --color='auto', which makes sure that diff does only output the relevant ANSI escape codes for ttys. Signed-off-by: Daniel Kral --- src/test/ha-tester.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/ha-tester.pl b/src/test/ha-tester.pl index 34f5ef1c..71aa59e3 100755 --- a/src/test/ha-tester.pl +++ b/src/test/ha-tester.pl @@ -46,7 +46,7 @@ sub do_run_test { my $logexpect = "$dir/log.expect"; if (-f $logexpect) { - my $cmd = ['diff', '-u', $logexpect, $logfile]; + my $cmd = ['diff', '--color', '-u', $logexpect, $logfile]; $res = system(@$cmd); return "Test '$dir' failed\n" if $res != 0; } else { -- 2.47.3