From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 777901FF13E for ; Fri, 17 Apr 2026 14:28:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 831E0C1D; Fri, 17 Apr 2026 14:28:08 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 5/7] pve-ha-tester: capture and fail for unexpected perl warnings Date: Fri, 17 Apr 2026 14:27:20 +0200 Message-ID: <20260417122728.330123-6-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260417122728.330123-1-d.kral@proxmox.com> References: <20260417122728.330123-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776428771715 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5WCDPO5WGMRF46JTH2J57GONNND5V3QD X-Message-ID-Hash: 5WCDPO5WGMRF46JTH2J57GONNND5V3QD X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Make any HA integration tests fail, which output some unexpected warning. This assumes that the HA stack's code always uses the PVE::HA::Env::log() interface to output any relevant information for users and the test cases. This catches any uninitialized values in the test cases early in the build/test process, which would have gone unnoticed before as these weren't considered failed tests. Signed-off-by: Daniel Kral --- src/pve-ha-tester | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/pve-ha-tester b/src/pve-ha-tester index b7dc4d66..5f13b460 100755 --- a/src/pve-ha-tester +++ b/src/pve-ha-tester @@ -19,6 +19,14 @@ sub show_usage { my $testdir = shift || show_usage(); my $hardware = PVE::HA::Sim::TestHardware->new($testdir); +$SIG{'__WARN__'} = sub { + my $err = $@; + my $message = $_[0]; + chomp $message; + $hardware->log('warn', $message, 'perl'); + $@ = $err; +}; + $hardware->log('info', "starting simulation"); eval { $hardware->run(); }; -- 2.47.3