From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3C1011FF13E for ; Fri, 17 Apr 2026 14:28:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1C62E994; Fri, 17 Apr 2026 14:28:06 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 3/7] sim: hardware: factor common service lock hash access in unlock_service Date: Fri, 17 Apr 2026 14:27:18 +0200 Message-ID: <20260417122728.330123-4-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260417122728.330123-1-d.kral@proxmox.com> References: <20260417122728.330123-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776428771599 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DRDH5TNX4RD3JOC4FPZ5JHVKP5SIDCOH X-Message-ID-Hash: DRDH5TNX4RD3JOC4FPZ5JHVKP5SIDCOH X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Daniel Kral --- src/PVE/HA/Sim/Hardware.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index 891d552f..88fd64e8 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -319,12 +319,14 @@ sub unlock_service { die "no such service '$sid'\n" if !$conf->{$sid}; - if (!defined($conf->{$sid}->{lock})) { + my $service_lock = $conf->{$sid}->{lock}; + + if (!defined($service_lock)) { return undef; } - if (defined($lock) && $conf->{$sid}->{lock} ne $lock) { - warn "found lock '$conf->{$sid}->{lock}' trying to remove '$lock' lock\n"; + if (defined($lock) && $service_lock ne $lock) { + warn "found lock '$service_lock' trying to remove '$lock' lock\n"; return undef; } -- 2.47.3