[PATCH ha-manager 0/7] some test logging output improvements

[Daniel Kral <d.kral@proxmox.com>]

This patch series makes some improvements on how tests output their
logs, especially to make any unexpected warnings fail the test cases.
This catches the typical 'uninitialized variable used' and other Perl
warnings, which would have gone unnoticed beforehand as there's much
more output on STDOUT than STDERR.

This is a small QoL improvement when working on the HA stack because it
catches newly introduced perl warnings early and a

    git rebase master --exec 'make clean && make deb'

with enough test branch coverage should give at least some confidence
that the individual patches are ordered correctly and do not introduce
Perl warnings.

Also a small patch at the end I've used locally for some time to better
highlight the diff output for failed test cases.



Daniel Kral (7):
  sim: always limit the priority level to 4 characters
  consistently use correct priority levels for log calls
  sim: hardware: factor common service lock hash access in
    unlock_service
  use log with warning priority instead of warn where possible
  pve-ha-tester: capture and fail for unexpected perl warnings
  test: ha-tester: use consistent word casing for failed test messages
  test: ha-tester: use colorized diff for unexpected test log outputs

 src/PVE/HA/Env.pm                        |  2 ++
 src/PVE/HA/Env/PVE2.pm                   |  4 ++--
 src/PVE/HA/Fence.pm                      |  2 +-
 src/PVE/HA/Manager.pm                    |  6 +++---
 src/PVE/HA/Resources/PVEVM.pm            |  2 +-
 src/PVE/HA/Sim/Env.pm                    |  2 ++
 src/PVE/HA/Sim/Hardware.pm               | 17 ++++++++++-------
 src/PVE/HA/Sim/RTEnv.pm                  |  1 +
 src/PVE/HA/Sim/RTHardware.pm             |  1 +
 src/PVE/HA/Sim/Resources/VirtCT.pm       |  2 +-
 src/PVE/HA/Sim/TestHardware.pm           |  1 +
 src/pve-ha-tester                        |  8 ++++++++
 src/test/ha-tester.pl                    |  6 +++---
 src/test/test-locked-service2/log.expect |  9 +++++++++
 14 files changed, 45 insertions(+), 18 deletions(-)

-- 
2.47.3