From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BFEED1FF13E for ; Fri, 17 Apr 2026 13:28:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E50B71EF66; Fri, 17 Apr 2026 13:28:06 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 2/2] ui: datastore: expose gc-on-unmount setting Date: Fri, 17 Apr 2026 13:27:55 +0200 Message-ID: <20260417112755.136134-3-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260417112755.136134-1-h.laimer@proxmox.com> References: <20260417112755.136134-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776425203510 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: M7MMNKGZGC37GTMNEFKAVJXO2LGTPOUC X-Message-ID-Hash: M7MMNKGZGC37GTMNEFKAVJXO2LGTPOUC X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Shows the gc-on-unmount option in the datastore options and allows editing for removable datastores. Signed-off-by: Hannes Laimer --- www/datastore/OptionView.js | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js index 160edd44..2b35355a 100644 --- a/www/datastore/OptionView.js +++ b/www/datastore/OptionView.js @@ -104,6 +104,7 @@ Ext.define('PBS.Datastore.Options', { let record = listStore.findRecord('store', me.datastore, 0, false, true, true); return { s3Visible: record?.get('backend-type') === 's3' ? undefined : false, + removableVisible: record?.get('mount-status') !== 'nonremovable' ? undefined : false, }; }, @@ -226,6 +227,28 @@ Ext.define('PBS.Datastore.Options', { }, }, }, + 'gc-on-unmount': { + required: true, + header: gettext('GC on Unmount'), + defaultValue: false, + renderer: Proxmox.Utils.format_boolean, + cbind: { + visible: '{removableVisible}', + }, + editor: { + xtype: 'proxmoxWindowEdit', + title: gettext('GC on Unmount'), + width: 350, + items: { + xtype: 'proxmoxcheckbox', + name: 'gc-on-unmount', + boxLabel: gettext('Run garbage collection before unmounting'), + defaultValue: false, + deleteDefaultValue: true, + deleteEmpty: true, + }, + }, + }, 'maintenance-mode': { required: true, header: gettext('Maintenance mode'), -- 2.47.3