From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 70DFC1FF13E for ; Fri, 17 Apr 2026 13:05:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BBB4B1E808; Fri, 17 Apr 2026 13:05:34 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Subject: [PATCH pve-access-control] ldap: decode attribute values as UTF-8 Date: Fri, 17 Apr 2026 13:04:51 +0200 Message-ID: <20260417110451.134766-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776423817949 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.081 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 64LVAJHL4S43AQH7DPGUZO5Q5SJBSPPV X-Message-ID-Hash: 64LVAJHL4S43AQH7DPGUZO5Q5SJBSPPV X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Net::LDAP's get_value() returns octets as raw bytes as received over the wire. Per RFC 4511 [0] LDAPString values are UTF-8 encoded, but Perl does not know that. PVE::Tools::encode_text() then re-encodes the bytes as UTF-8, producing a double-encoded sequence that ends up in user.cfg for any non-ASCII name. On read decode_text() only undoes one layer, so the GUI and CLI render the partially-decoded middle form instead of the original text. Decode the value as UTF-8 right after retrieval so that downstream code operates on a proper character string and encode_text() produces single-encoded UTF-8. [0] https://datatracker.ietf.org/doc/html/rfc4511#section-4.1.2 Reported-by: https://forum.proxmox.com/threads/support-for-unicode-characters-in-usernames.182832/ Signed-off-by: Hannes Laimer --- src/PVE/Auth/LDAP.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/Auth/LDAP.pm b/src/PVE/Auth/LDAP.pm index 093863c..ae17878 100755 --- a/src/PVE/Auth/LDAP.pm +++ b/src/PVE/Auth/LDAP.pm @@ -3,6 +3,8 @@ package PVE::Auth::LDAP; use strict; use warnings; +use Encode; + use PVE::Auth::Plugin; use PVE::JSONSchema; use PVE::LDAP; @@ -330,6 +332,11 @@ sub get_users { foreach my $attr (keys %$user_attributes) { if (my $ours = $ldap_attribute_map->{$attr}) { my $value = $user_attributes->{$attr}->[0]; + # Net::LDAP returns octets; DirectoryString-syntax attributes + # (sn, givenName, mail, description, ...) are UTF-8 on the + # wire, so mark them as such before we hand them off to the + # rest of the stack, which assumes character strings. + $value = Encode::decode('UTF-8', $value) if defined($value); eval { verify_sync_attribute_value($ours, $value) }; if (my $err = $@) { warn "skipping attribute mapping '$attr'->'$ours' for user '$username' - $err"; -- 2.47.3