all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com
Subject: [PATCH yew-widget-toolkit] touch: gesture destector: fix double -> multi transition with pointers
Date: Fri, 17 Apr 2026 08:58:23 +0200	[thread overview]
Message-ID: <20260417065908.120149-1-d.csapak@proxmox.com> (raw)

when a third pointer is added, we accidentally didn't trigger
the pinch/zoom end callback

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
is a followup to
https://lore.proxmox.com/yew-devel/20260416085849.1062721-1-d.csapak@proxmox.com/T/#t

but can be squashed in if preferred

 src/touch/gesture_detector.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/touch/gesture_detector.rs b/src/touch/gesture_detector.rs
index 17bf072..f91d16b 100644
--- a/src/touch/gesture_detector.rs
+++ b/src/touch/gesture_detector.rs
@@ -961,8 +961,10 @@ impl PwtGestureDetector {
             Msg::PointerDown(event) => {
                 let pointer_count = self.pointers.len();
                 assert!(pointer_count == 2);
+                let (point0, point1) = self.get_pinch_points();
                 self.register_pointer(ctx, &event);
                 self.state = DetectionState::Multi;
+                self.call_on_pinch_zoom(ctx, point0, point1, GesturePhase::End);
             }
             Msg::TouchStart(event) => {
                 let pointer_count = self.pointers.len();
-- 
2.47.3





             reply	other threads:[~2026-04-17  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  6:58 Dominik Csapak [this message]
2026-04-17  7:06 ` applied: " Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417065908.120149-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal