From: Koji Nishimura <nsm.kkoji@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: Koji Nishimura <nsm.kkoji@gmail.com>
Subject: [PATCH] fix #6079: use vncticket endpoint for VM serial terminal
Date: Fri, 17 Apr 2026 02:40:46 +0900 [thread overview]
Message-ID: <20260416174046.38591-1-nsm.kkoji@gmail.com> (raw)
Use the vncticket endpoint for the VM serial terminal termproxy path.
The node shell termproxy path already uses the vncticket endpoint,
but the VM serial terminal path still uses the older authentication
flow.
That older flow prevents VM /termproxy from working with API tokens,
because authentication fails before the websocket connection can use
the VNC ticket verification path.
Make the VM serial terminal path use the same vncticket-based
authentication flow as the node shell path.
This fixes the VM /termproxy side of bug 6079. In local testing,
this was required together with the already-posted access-control
change for token-owned VNC ticket verification.
Signed-off-by: Koji Nishimura <nsm.kkoji@gmail.com>
---
src/PVE/API2/Qemu.pm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index 2a1e3854..0b8859fb 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -3152,7 +3152,16 @@ __PACKAGE__->register_method({
syslog('info', "starting qemu termproxy $upid\n");
my $cmd =
- ['/usr/bin/termproxy', $port, '--path', $authpath, '--perm', 'VM.Console', '--'];
+ [
+ '/usr/bin/termproxy',
+ $port,
+ '--path',
+ $authpath,
+ '--perm',
+ 'VM.Console',
+ '--vncticket-endpoint',
+ '--',
+ ];
push @$cmd, @$remcmd, @$termcmd;
run_command($cmd);
--
2.43.0
reply other threads:[~2026-04-20 14:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416174046.38591-1-nsm.kkoji@gmail.com \
--to=nsm.kkoji@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.