From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7D0A21FF13A for ; Wed, 15 Apr 2026 15:21:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D2C76150A2; Wed, 15 Apr 2026 15:21:07 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager v4 09/12] pdm: node rrd data: rename 'total-time' to 'metric-collection-total-time' Date: Wed, 15 Apr 2026 15:20:10 +0200 Message-ID: <20260415132013.440581-10-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415132013.440581-1-l.wagner@proxmox.com> References: <20260415132013.440581-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776259154881 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: J6I7DAFVF7SRCD54PPHKFE3XVKA6FSGL X-Message-ID-Hash: J6I7DAFVF7SRCD54PPHKFE3XVKA6FSGL X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In the initial version of the remote metric collection series, there was a separate API endpoint for metric collection rrd data, hence the short name. Unfortunately we forgot to rename the field when the metric collection stats were move the PDM host stats. Neither the client tool nor the UI used this field yet, and also we didn't stabilize PDMs API yet, so it should be fine to just rename the field. Signed-off-by: Lukas Wagner Reviewed-by: Arthur Bied-Charreton Reviewed-by: Michael Köppl Tested-by: Arthur Bied-Charreton Tested-by: Michael Köppl --- lib/pdm-api-types/src/rrddata.rs | 2 +- server/src/api/nodes/rrddata.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/pdm-api-types/src/rrddata.rs b/lib/pdm-api-types/src/rrddata.rs index 70619233..6eaaff3c 100644 --- a/lib/pdm-api-types/src/rrddata.rs +++ b/lib/pdm-api-types/src/rrddata.rs @@ -242,7 +242,7 @@ pub struct PdmNodeDatapoint { /// Total time in milliseconds needed for full metric collection run. #[serde(skip_serializing_if = "Option::is_none")] - pub total_time: Option, + pub metric_collection_total_time: Option, } #[api] diff --git a/server/src/api/nodes/rrddata.rs b/server/src/api/nodes/rrddata.rs index 4c2302c8..00c4eee0 100644 --- a/server/src/api/nodes/rrddata.rs +++ b/server/src/api/nodes/rrddata.rs @@ -23,7 +23,7 @@ impl DataPoint for PdmNodeDatapoint { fn set_field(&mut self, name: &str, value: f64) { if name == "metric-collection-total-time" { - self.total_time = Some(value); + self.metric_collection_total_time = Some(value); } } } -- 2.47.3