From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 69BBB1FF13A for ; Wed, 15 Apr 2026 10:32:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3AFC9840B; Wed, 15 Apr 2026 10:32:37 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup] config: lock guard: label BackupLockGuard by must_use attribute Date: Wed, 15 Apr 2026 10:31:45 +0200 Message-ID: <20260415083146.187139-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776241844995 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs] Message-ID-Hash: KY2BHDM5ZFIQNJQ6BGTUMGE2OY5AGDLN X-Message-ID-Hash: KY2BHDM5ZFIQNJQ6BGTUMGE2OY5AGDLN X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The BackupLockGuard is used to store the open file descriptor of a flocked file. Once dropped, the file lock is release. Since not binding the BackupLockGuard to a variable will result in dropping of the struct and therefore immediate unlocking of the file, set the must_use attribute with a meaningful description to get clippy warnings for this. Suggested-by: Daniel Kral Suggested-by: Thomas Lamprecht Signed-off-by: Christian Ebner --- pbs-config/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/pbs-config/src/lib.rs b/pbs-config/src/lib.rs index 18b27d23a..88a31904f 100644 --- a/pbs-config/src/lib.rs +++ b/pbs-config/src/lib.rs @@ -59,6 +59,7 @@ pub fn priv_user() -> Result { } } +#[must_use = "lock guard must be used to keep file locked"] pub struct BackupLockGuard { file: Option, // TODO: Remove `_legacy_dir` with PBS 5 -- 2.47.3