From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 41E241FF13A for ; Wed, 15 Apr 2026 09:02:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 879352E88; Wed, 15 Apr 2026 09:02:28 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox v3 06/23] notify: smtp: Infer auth method for backwards compatibility Date: Wed, 15 Apr 2026 09:02:03 +0200 Message-ID: <20260415070220.100306-7-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415070220.100306-1-a.bied-charreton@proxmox.com> References: <20260415070220.100306-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.126 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: GDHHRSMVYSL5MMPR33YGBRJRNAKDVHBT X-Message-ID-Hash: GDHHRSMVYSL5MMPR33YGBRJRNAKDVHBT X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: If not set, infer the auth_method SmtpConfig field from the presence of a password in the config. This makes sure the new API stays backwards-compatible with old scripts and updates old configurations when they are edited. Signed-off-by: Arthur Bied-Charreton --- proxmox-notify/src/api/smtp.rs | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/proxmox-notify/src/api/smtp.rs b/proxmox-notify/src/api/smtp.rs index b265c26a..71284f63 100644 --- a/proxmox-notify/src/api/smtp.rs +++ b/proxmox-notify/src/api/smtp.rs @@ -56,6 +56,20 @@ fn get_private_config(config: &Config, name: &str) -> Result SmtpConfig { + if config.auth_method.is_none() && private_config.password.is_some() { + SmtpConfig { + auth_method: Some(SmtpAuthMethod::Plain), + ..config + } + } else { + config + } +} + /// Add a new smtp endpoint. /// /// The caller is responsible for any needed permission checks. @@ -90,11 +104,13 @@ pub fn add_endpoint( super::set_private_config_entry( config, - private_endpoint_config, + &private_endpoint_config, SMTP_TYPENAME, &endpoint_config.name, )?; + let endpoint_config = infer_auth_method(endpoint_config, private_endpoint_config); + config .config .set_data(&endpoint_config.name, SMTP_TYPENAME, &endpoint_config) @@ -209,6 +225,8 @@ pub fn update_endpoint( } })?; + let endpoint = infer_auth_method(endpoint, get_private_config(config, name)?); + config .config .set_data(name, SMTP_TYPENAME, &endpoint) -- 2.47.3