From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C62241FF140 for ; Fri, 10 Apr 2026 16:01:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 93E891F106; Fri, 10 Apr 2026 16:01:55 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com Subject: [PATCH datacenter-manager 4/4] api: views: improve API schema definitions Date: Fri, 10 Apr 2026 16:01:19 +0200 Message-ID: <20260410140119.338714-5-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260410140119.338714-1-l.wagner@proxmox.com> References: <20260410140119.338714-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775829611710 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LI6O4HM3IRC7SEG3I3AMHRG6FUD65K5S X-Message-ID-Hash: LI6O4HM3IRC7SEG3I3AMHRG6FUD65K5S X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Signed-off-by: Lukas Wagner --- server/src/api/config/views.rs | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/server/src/api/config/views.rs b/server/src/api/config/views.rs index db68da5d..e1da725d 100644 --- a/server/src/api/config/views.rs +++ b/server/src/api/config/views.rs @@ -8,7 +8,7 @@ use proxmox_schema::{api, param_bail}; use pdm_api_types::{ views::{ViewConfig, ViewConfigEntry, ViewConfigUpdater, ViewTemplate}, - PRIV_RESOURCE_AUDIT, PRIV_RESOURCE_MODIFY, + PRIV_RESOURCE_AUDIT, PRIV_RESOURCE_MODIFY, VIEW_ID_SCHEMA, }; const VIEW_ROUTER: Router = Router::new() @@ -30,8 +30,7 @@ pub const ROUTER: Router = Router::new() description: "List of views.", type: Array, items: { - type: String, - description: "The name of a view." + type: ViewConfig, }, }, )] @@ -130,8 +129,7 @@ pub enum DeletableProperty { input: { properties: { id: { - type: String, - description: "", + schema: VIEW_ID_SCHEMA, }, view: { flatten: true, @@ -215,8 +213,7 @@ pub fn update_view( input: { properties: { id: { - type: String, - description: "", + schema: VIEW_ID_SCHEMA, }, digest: { type: ConfigDigest, @@ -250,8 +247,7 @@ pub fn remove_view(id: String, digest: Option) -> Result<(), Error input: { properties: { id: { - type: String, - description: "", + schema: VIEW_ID_SCHEMA, }, }, }, -- 2.47.3