From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B7FFB1FF13A for ; Wed, 01 Apr 2026 16:09:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4B6911EEA5; Wed, 1 Apr 2026 16:09:45 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/3] api: backup: drop starttime and dow from return schema Date: Wed, 1 Apr 2026 16:09:00 +0200 Message-ID: <20260401140903.364176-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401140903.364176-1-l.wagner@proxmox.com> References: <20260401140903.364176-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775052490874 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.447 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2RQJA5CF5AT3GTEIWOJLZMMMND66UO3S X-Message-ID-Hash: 2RQJA5CF5AT3GTEIWOJLZMMMND66UO3S X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For backup jobs returned by the API, the `dow` and `starttime` parameters are only ever set for legacy-jobs that are defined in the old vzdump.cron configuration file. The newer backup jobs based on the jobs.cfg file were introduced in [0]. Ever since then, any new or updated backup job was stored in jobs.cfg, meaning that it is rather unlikely to have any backup jobs in the old configuration file anyways, from which subsequently follows that the 'dow' and 'starttime' params will hardly ever be included in the response anyways. And even if a legacy job is read from the old file, an appropriate 'schedule' key is automatically synthesized from 'dow' and 'starttime'. In summary: - 'dow' and 'starttime' will hardly ever be set - 'schedule' will ALWAYS be set - any client needed to understand the 'schedule' parameter since 7.1 anyways It should therefore be fine to just drop both old keys from the return schema; this is a good chance to clean up some legacy cruft. [0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=305921b1a Suggested-by: Thomas Lamprecht Signed-off-by: Lukas Wagner --- PVE/API2/Backup.pm | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 1d6d4257..2ab78834 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -129,21 +129,6 @@ my $backup_job_return_schema = PVE::VZDump::Common::json_config_properties({ maxLength => 128, optional => 1, }, - starttime => { - type => 'string', - description => "Job start-time (server timezone); deprecated and replaced by schedule.", - pattern => '\d{1,2}:\d{1,2}', - typetext => 'HH:MM', - optional => 1, - }, - dow => { - type => 'string', - format => 'pve-day-of-week-list', - optional => 1, - description => "Day of week selection; deprecated and replaced by schedule.", - requires => 'starttime', - default => ALL_DAYS, - }, enabled => { type => 'boolean', optional => 1, -- 2.47.3