From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BF63E1FF13A for ; Wed, 01 Apr 2026 10:01:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 90FD7122B6; Wed, 1 Apr 2026 10:00:59 +0200 (CEST) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 16/17] ui: VMCPUFlagSelector: Add search bar for large lists of flags Date: Wed, 1 Apr 2026 10:00:27 +0200 Message-ID: <20260401080028.62513-17-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401080028.62513-1-a.bied-charreton@proxmox.com> References: <20260401080028.62513-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Message-ID-Hash: LUUYCVDXVHVRAOJTCNADUJESUEZLDFBO X-Message-ID-Hash: LUUYCVDXVHVRAOJTCNADUJESUEZLDFBO X-MailFrom: abied-charreton@jett.proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a search bar for the CPU flags list queried from /cluster/qemu/cpu-flags, which is very long. Do not display it for VM-specific flags (~15 flags), as they are easier to scan through, and it would overload the ProcessorEdit window. Signed-off-by: Arthur Bied-Charreton --- www/manager6/form/VMCPUFlagSelector.js | 128 ++++++++++++++++--------- 1 file changed, 83 insertions(+), 45 deletions(-) diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js index 765d325d..4c6e1510 100644 --- a/www/manager6/form/VMCPUFlagSelector.js +++ b/www/manager6/form/VMCPUFlagSelector.js @@ -68,7 +68,11 @@ Ext.define('PVE.form.VMCPUFlagSelector', { let flags = ''; - store.getData().each(function (rec) { + // Get the values directly from the data source. Using store.getData() here + // would iterate over the filtered values, potentially overwriting flags that + // are set but currently filtered out by the search bar. + let source = store.getDataSource(); + source.each(function (rec) { let s = rec.get('state'); if (s && s !== '=') { let f = rec.get('name'); @@ -286,57 +290,91 @@ Ext.define('PVE.form.VMCPUFlagSelector', { me.value = me.originalValue = ''; - me.dockedItems = [ + let topToolbarItems = [ { - xtype: 'toolbar', - dock: 'top', - hidden: false, + xtype: 'tbtext', + text: gettext('Acceleration:'), + autoEl: { + tag: 'span', + 'data-qtip': gettext( + "A custom CPU model using acceleration-specific flags can only be assigned to VMs configured with the matching acceleration type, i.e., 'kvm: 1' for KVM, or 'kvm: 0' for TCG.", + ), + }, + }, + { + xtype: 'radiogroup', + layout: 'hbox', + validateOnChange: false, items: [ { - xtype: 'tbtext', - text: gettext('Acceleration:'), - autoEl: { - tag: 'span', - 'data-qtip': gettext( - 'A custom CPU model using acceleration-specific flags can only be assigned to VMs configured with the matching acceleration type, i.e., "kvm: 1" for KVM, or "kvm: 0" for TCG.', - ), - }, + boxLabel: 'KVM', + inputValue: 'kvm', + name: 'accel', + checked: true, + isFormField: false, }, { - xtype: 'radiogroup', - layout: 'hbox', - validateOnChange: false, - items: [ - { - boxLabel: 'KVM', - inputValue: 'kvm', - name: 'accel', - checked: true, - isFormField: false, - }, - { - boxLabel: 'TCG', - inputValue: 'tcg', - name: 'accel', - margin: '0 0 0 10', - isFormField: false, - }, - ], - listeners: { - change: function (_, value) { - let view = this.up('grid'); - let proxy = view.getStore().getProxy(); - let accel = value.accel; - if (accel) { - proxy.setExtraParam('accel', accel); - } else { - delete proxy.extraParams.accel; - } - view.getStore().load(); - }, - }, + boxLabel: 'TCG', + inputValue: 'tcg', + name: 'accel', + margin: '0 0 0 10', + isFormField: false, }, ], + listeners: { + change: function (_, value) { + let view = this.up('grid'); + let proxy = view.getStore().getProxy(); + let accel = value.accel; + if (accel) { + proxy.setExtraParam('accel', accel); + } else { + delete proxy.extraParams.accel; + } + view.getStore().load(); + }, + }, + }, + ]; + + if (!me.restrictToVMFlags) { + topToolbarItems.push('-', { + xtype: 'textfield', + emptyText: gettext('Search...'), + submitValue: false, + listeners: { + change: { + buffer: 100, + fn: function (field, value) { + let store = field.up('grid').getStore(); + if (value) { + let lv = value.toLowerCase(); + store.addFilter({ + id: 'search-filter', + filterFn: (rec) => { + let name = rec.get('name') || ''; + let desc = rec.get('description') || ''; + return ( + name.toLowerCase().includes(lv) || + desc.toLowerCase().includes(lv) + ); + }, + }); + } else { + store.removeFilter('search-filter'); + } + }, + }, + }, + }); + } + + me.dockedItems = [ + { + xtype: 'toolbar', + dock: 'top', + hidden: false, + items: topToolbarItems, }, ]; -- 2.47.3