From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 773071FF137 for ; Tue, 31 Mar 2026 13:50:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 160B81A19E; Tue, 31 Mar 2026 13:50:20 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 7/7] lvm plugin: schema: align description of 'tagged_only' with actual behavior Date: Tue, 31 Mar 2026 13:49:55 +0200 Message-ID: <20260331115011.102276-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com> References: <20260331115011.102276-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774957758775 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.494 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OMIVIJUWNQUB35PS4LIU7FU3MTBDMTBC X-Message-ID-Hash: OMIVIJUWNQUB35PS4LIU7FU3MTBDMTBC X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The only thing that the 'tagged_only' property affects is the list_images() method and this has been the case since the option was introduced 10 years ago with commit 7a9dd11 ("add tagged_only option to LVM storage"). There are no other checks against using such volumes if their name adheres to the vm-ID-XYZ schema. For example, they can be accessed via 'pvesm free' and assigned to a VM with 'qm set'. If such checks are added, that should be done as part of a major release to avoid breaking any existing setup. Document the actual behavior for now. Signed-off-by: Fiona Ebner --- New in v2. src/PVE/Storage/LVMPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index b4cb0c5..ff8c5f4 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -440,7 +440,7 @@ sub properties { type => 'string', }, tagged_only => { - description => "Only use logical volumes tagged with 'pve-vm-ID'.", + description => "Only list logical volumes tagged with 'pve-vm-ID'.", type => 'boolean', }, }; -- 2.47.3