From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9A5071FF137 for ; Tue, 31 Mar 2026 13:50:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D0191A5E3; Tue, 31 Mar 2026 13:50:51 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 4/7] lvm plugin: remove cryptic partial comment Date: Tue, 31 Mar 2026 13:49:52 +0200 Message-ID: <20260331115011.102276-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com> References: <20260331115011.102276-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774957758596 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.495 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QCTVV3CFWOYJLY4QRUFXJNZ6TPZBQGT6 X-Message-ID-Hash: QCTVV3CFWOYJLY4QRUFXJNZ6TPZBQGT6 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This partial comment was added with commit c8943a8 ("remove non used parameter exclusive") back in 2015, but there is no explanation what it means or what the fix me refers to, not even on the mailing list [0]. Just remove the comment now after 10 years, to avoid confusing people. If there really is something to fix, then it should resurface as an actual issue. There also seems to be a typo, since 'lvmchange' was a pre-LVM2 command to "change attributes of the logical volume manager" [1] rather than individual LVs and even at the time of commit c8943a8, the 'lvchange' command was used by the activate_volume() method and there is no further reference to 'lvmchange' in the pve-storage git history. [0]: https://lists.proxmox.com/pipermail/pve-devel/2015-September/017233.html [1]: https://gitlab.com/lvmteam/lvm2/-/commit/8ef93c756eecc2036f0c945c80972902f27970ca Signed-off-by: Fiona Ebner --- New in v2. src/PVE/Storage/LVMPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index cd4d07a..7ef148b 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -954,7 +954,7 @@ sub deactivate_storage { sub activate_volume { my ($class, $storeid, $scfg, $volname, $snapname, $cache) = @_; - #fix me lvmchange is not provided on + my $path = $class->path($scfg, $volname, $storeid, $snapname); my $lvm_activate_mode = 'ey'; -- 2.47.3