From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4B21A1FF137 for ; Tue, 31 Mar 2026 13:50:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68F621A3DB; Tue, 31 Mar 2026 13:50:49 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH storage v2 3/7] lvm plugin: rename: update tags when renaming Date: Tue, 31 Mar 2026 13:49:51 +0200 Message-ID: <20260331115011.102276-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331115011.102276-1-f.ebner@proxmox.com> References: <20260331115011.102276-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774957758540 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PHUQXMOZDJ2PMX62RP7P4I4A6CATA657 X-Message-ID-Hash: PHUQXMOZDJ2PMX62RP7P4I4A6CATA657 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The rename_volume() function is used when reassigning a volume to a different VM. When a volume is created, a tag 'pve-vm-ID' with the VM ID is added to the volume, and for qcow2, additionally a tag with the volume name. Replace the tag(s) with one(s) for the new VM ID (and new volume name for qcow2) after renaming to keep them consistent. Signed-off-by: Fiona Ebner --- New in v2. src/PVE/Storage/LVMPlugin.pm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 8392c89..cd4d07a 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -1454,6 +1454,18 @@ sub rename_volume { if ($lvs->{$vg}->{$target_volname}); lvrename($scfg, $source_volname, $target_volname); + + eval { + my $tag_opts = + ['--addtag', "pve-vm-${target_vmid}", '--deltag', "pve-vm-${source_vmid}"]; + if ($format eq 'qcow2') { + push $tag_opts->@*, '--addtag', "pve-$target_volname"; + push $tag_opts->@*, '--deltag', "pve-$source_volname"; + } + run_command(['lvchange', $tag_opts->@*, "${vg}/${target_volname}"]); + }; + warn "unable to update tags for '$target_volname' - $@" if $@; + return "${storeid}:${target_volname}"; } -- 2.47.3