From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 85D6B1FF137 for ; Tue, 31 Mar 2026 04:07:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 00451B26F; Tue, 31 Mar 2026 04:07:53 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager 0/1] ceph: pool: fix pool statistics filter returning wrong pool's data Date: Tue, 31 Mar 2026 10:07:38 +0800 Message-ID: <20260331020739.818888-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774922809897 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.126 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 56S6Q3Q7K3VZNFIQR7PTSW4YPFC7O7ZS X-Message-ID-Hash: 56S6Q3Q7K3VZNFIQR7PTSW4YPFC7O7ZS X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: While reading the code I noticed the condition: next if !defined($d->{name}) && !$d->{name} ne "$pool"; I tried to simplify it using De Morgan's law: next if !(defined($d->{name}) || $d->{name} ne "$pool"); That immediately looked wrong -- we use the pattern 'defined($foo) && $foo ne "needle"' as a null-safe equality check in many languages, but here the operator was '&&' combined with negation on both sides, which doesn't match that pattern at all. Looking closer, I realised the original condition is simply a logic error: '&&' short-circuits when the first clause is false, so the name comparison is never reached for any entry that has a defined name. All pools with a defined name pass through, and the loop overwrites $data->{statistics} on every iteration, leaving the stats of whichever pool happens to be last in the 'ceph df' output. The !defined() guard also intrigued me -- could 'name' ever be absent from the response? Reading the Ceph source (PGMap.cc:dump_pool_stats_full) shows that f->dump_string("name", pool_name) is called unconditionally for every pool entry. Multiple mgr modules (influx, prometheus, telegraf) also access pool['name'] directly without any None check, confirming it is part of the established contract. The fix removes both the logic error and the now-unnecessary !defined() guard, simplifying the condition to a plain string comparison. Kefu Chai (1): ceph: pool: fix pool statistics filter returning wrong pool's data PVE/API2/Ceph/Pool.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.47.3