From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EB63B1FF137 for ; Tue, 31 Mar 2026 02:41:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 65681AB91; Tue, 31 Mar 2026 02:42:01 +0200 (CEST) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager 1/1] pve8to9: fix package lookup empty result check Date: Tue, 31 Mar 2026 08:41:19 +0800 Message-ID: <20260331004119.707556-2-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331004119.707556-1-k.chai@proxmox.com> References: <20260331004119.707556-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774917631825 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.361 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2VSRMN4EHVRJGMNW4S6WKZ5CTAH3J6EK X-Message-ID-Hash: 2VSRMN4EHVRJGMNW4S6WKZ5CTAH3J6EK X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The empty result guard used two conditions that are always false for an array reference: if (!defined $pkgs || $pkgs == 0) { '$pkgs' from '[grep {...} @list]' is always defined, and '$pkgs == 0' numifies the reference (memory address), which is never zero. The diagnostic log_fail message was therefore never emitted when a package was not found in the version list. Replace with '!@$pkgs' to correctly test whether the array is empty. Signed-off-by: Kefu Chai --- PVE/CLI/pve8to9.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 0c4b2343..afc4785e 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -175,7 +175,7 @@ my $get_pkg = sub { } my $pkgs = [grep { $_->{Package} eq $pkg } @$versions]; - if (!defined $pkgs || $pkgs == 0) { + if (!@$pkgs) { log_fail("unable to determine installed $pkg version."); return undef; } else { -- 2.47.3