From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0EEA41FF141 for ; Mon, 30 Mar 2026 23:48:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E448A94D0; Mon, 30 Mar 2026 23:48:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=rchrist.io; s=default; t=1774906780; bh=nj03QyEXp+mhDdQfvLz/xt3X7SvqcDppdZDtqEjnOKg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b2sm4Zh1tmIUU3PpNbgeqSp6weRwLTgw70bR9JhpUDyd/LbtKUPbbdKov/qcNny7I 0VUy767Sq6sR8dN3ap6J/Wv8rHkN8l8E5eYYWVHvztDMqukewUZuv7hnxrYPovPwBr 8Ngank8qmJU9bvlcLg5oKTeMBW3WMRVAzgPZP53iL3qd4nNnWxeEquCdqBjP3Y0Bn6 /C87XdVBIDwuojPjNCmYbQWYbgWrF/0rmGeqZow6lU2/cLAAO16bO+B4Fu7KlK2Cyp 0tJQDYjt18ReixDJjJq31HzNKjM+tlgDNqEfIZv3nm981XWIjXBWNRZoVFhaWXxGJZ Y1WLy4Gn7NWaA== From: Robin Christ To: pve-devel@lists.proxmox.com Subject: [PATCH ifupdown2 2/4] nlcache: Add missing link_set_mtu_dry_run method Date: Mon, 30 Mar 2026 23:39:19 +0200 Message-ID: <20260330213921.533853-3-robin@rchrist.io> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260330213921.533853-1-robin@rchrist.io> References: <20260330213921.533853-1-robin@rchrist.io> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4fl4Ql3Fqnz2xHf X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_MISSING 0.1 Missing DMARC policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MVCKZ55CFP57ZPQCIM3JTP5AC5R6HCKR X-Message-ID-Hash: MVCKZ55CFP57ZPQCIM3JTP5AC5R6HCKR X-MailFrom: robin@rchrist.io X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Robin Christ X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Robin Christ nlcache NetlinkListenerWithCache got a new link_set_mtu based on netlink at some point, but never the dry run variant link_set_mtu_dry_run, breaking dry runs Signed-off-by: Robin Christ --- ...-missing-link_set_mtu_dry_run-method.patch | 25 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 26 insertions(+) create mode 100644 debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch diff --git a/debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch b/debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch new file mode 100644 index 0000000..f90dd78 --- /dev/null +++ b/debian/patches/pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch @@ -0,0 +1,25 @@ +From: Robin Christ +Date: Mon, 30 Mar 2026 18:59:04 +0200 +Subject: nlcache: Add missing link_set_mtu_dry_run method + +nlcache NetlinkListenerWithCache got a new link_set_mtu based on netlink at some point, but never the dry run variant link_set_mtu_dry_run, breaking dry runs + +Signed-off-by: Robin Christ +--- + ifupdown2/lib/nlcache.py | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/ifupdown2/lib/nlcache.py b/ifupdown2/lib/nlcache.py +index a92ac6f..2d37443 100644 +--- a/ifupdown2/lib/nlcache.py ++++ b/ifupdown2/lib/nlcache.py +@@ -3331,6 +3331,9 @@ class NetlinkListenerWithCache(nllistener.NetlinkManagerWithListener, BaseObject + + ### + ++ def link_set_mtu_dry_run(self, ifname, mtu): ++ self.log_info_ifname_dry_run(ifname, "netlink: ip link set dev %s mtu %s" % (ifname, mtu)) ++ + """ + Sets the MTU of the given link, updating the cache on success. + diff --git a/debian/patches/series b/debian/patches/series index 8655369..45d92cb 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -17,3 +17,4 @@ upstream/0002-vxlan-add-support-for-IPv6-vxlan-local-tunnelip.patch pve/0014-nlmanager-read-ipv6-devconf-disable_ipv6-attribute-t.patch pve/0015-revert-addons-bond-warn-if-sub-interface-is-detected-on-bond-slave.patch pve/0016-nlcache-fix-missing-nodad-option-in-addr_add_dry_run.patch +pve/0017-nlcache-add-missing-link_set_mtu_dry_run-method.patch -- 2.47.3