From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 75DCF1FF141 for ; Mon, 30 Mar 2026 16:42:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 512023651F; Mon, 30 Mar 2026 16:41:42 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v3 29/40] add running flag to non-HA cluster service stats Date: Mon, 30 Mar 2026 16:30:38 +0200 Message-ID: <20260330144101.668747-30-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260330144101.668747-1-d.kral@proxmox.com> References: <20260330144101.668747-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774881614717 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5ZPBEH67GNH4BZQPF53NHEY7Z4DTRKPC X-Message-ID-Hash: 5ZPBEH67GNH4BZQPF53NHEY7Z4DTRKPC X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The running flag is needed to discriminate starting and started resources from each other, which is a required parameter for using the new add_service(...) method for the resource scheduling bindings. The HA Manager tracks whether HA resources are in 'started' state and whether the LRM acknowledged that these are running. For non-HA resources, the rrd_dump data contains a running flag for VM and CT guests. See the next patch for the usage implementations, which passes the running flag to the add_service(...) method, for more information about the details. Signed-off-by: Daniel Kral --- changes v2 -> v3: - change the patch message and summary such that is clear that this patch is only really relevant to make non-HA cluster resources also have the running flag src/PVE/HA/Env/PVE2.pm | 1 + src/PVE/HA/Manager.pm | 2 +- src/PVE/HA/Sim/Hardware.pm | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PVE/HA/Env/PVE2.pm b/src/PVE/HA/Env/PVE2.pm index b2488ddd..97291594 100644 --- a/src/PVE/HA/Env/PVE2.pm +++ b/src/PVE/HA/Env/PVE2.pm @@ -549,6 +549,7 @@ my sub get_cluster_service_stats { id => $id, node => $nodename, state => $state, + running => $state eq 'started', type => $type, usage => {}, }; diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index 71f45b5c..5b2715c7 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -292,7 +292,7 @@ sub recompute_online_node_usage { next if $self->{ss}->{$sid}; # the migration target is not known for non-HA resources - my $sd = { $service_stats->{$sid}->%{qw(node state)} }; + my $sd = { $service_stats->{$sid}->%{qw(node state running)} }; $online_node_usage->add_service_usage($sid, $sd); } diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index 5693df0f..986cb084 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -1201,6 +1201,7 @@ my sub get_cluster_service_stats { $stats->{$sid} = { node => $cfg->{node}, state => $cfg->{state}, + running => $cfg->{state} eq 'started', usage => {}, }; } -- 2.47.3