From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 161B91FF141 for ; Mon, 30 Mar 2026 16:11:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E87D32E87; Mon, 30 Mar 2026 16:11:42 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Subject: [PATCH container v2 1/7] namespaces: relax prototype of run_in_userns Date: Mon, 30 Mar 2026 16:10:12 +0200 Message-ID: <20260330141021.151921-2-f.schauer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260330141021.151921-1-f.schauer@proxmox.com> References: <20260330141021.151921-1-f.schauer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774879814020 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JHYLHX6OUHUFKFRZAHXN3DUR4BBKQEKE X-Message-ID-Hash: JHYLHX6OUHUFKFRZAHXN3DUR4BBKQEKE X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allow passing a coderef stored in a private variable as the $code argument. This fixes the following compile-time error: Type of arg 1 to PVE::LXC::Namespaces::run_in_userns must be block or sub {} (not private variable) at PVE/LXC/Create.pm line 736 Signed-off-by: Filip Schauer --- src/PVE/LXC/Namespaces.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Namespaces.pm b/src/PVE/LXC/Namespaces.pm index aa62659..3b86262 100644 --- a/src/PVE/LXC/Namespaces.pm +++ b/src/PVE/LXC/Namespaces.pm @@ -25,7 +25,7 @@ my sub set_id_map($$) { PVE::Tools::run_command(['newuidmap', $pid, @uid_args]) if scalar(@uid_args); } -sub run_in_userns(&;$) { +sub run_in_userns($;$) { my ($code, $id_map) = @_; socketpair(my $sp, my $sc, AF_UNIX, SOCK_STREAM, PF_UNSPEC) or die "socketpair: $!\n"; -- 2.47.3