From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DD3121FF143 for ; Sat, 28 Mar 2026 12:31:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F309D5818; Sat, 28 Mar 2026 12:31:38 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: Re: [PATCH manager] ceph: init: clean up deprecated pg_bits parameter Date: Sat, 28 Mar 2026 19:31:26 +0800 Message-ID: <20260328113126.1144445-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <9bb47f57-f91d-4090-8b02-63014549686a@proxmox.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774697443092 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.359 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V7JPQFERYOOOYURYI24LZP4R5JQ652SP X-Message-ID-Hash: V7JPQFERYOOOYURYI24LZP4R5JQ652SP X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks Maximiliano for the review, and Thomas for catching the API compatibility issue. Thomas is absolutely right that this is a breaking API change. I was thinking about it through a Ceph lens, where `main` is a development branch and releases are cut from stable branches — so removing a deprecated parameter from `main` wouldn't affect any released version. Proxmox VE's release model is different: `master` is the release branch for the current major version, meaning API changes on `master` affect users immediately without a major version boundary as a natural breakpoint. Good to have that clarified. I've submitted v2 that keeps `pg_bits` as a documented no-op (with a TODO to remove it in PVE 10) while still dropping the dead-code comments: https://lore.proxmox.com/pve-devel/20260328112307.1131390-1-k.chai@proxmox.com/