From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 181281FF140 for ; Fri, 27 Mar 2026 14:22:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05EF1AD63; Fri, 27 Mar 2026 14:23:12 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perltidy] use more explicit --cuddled-blocks rather than --cuddled-else Date: Fri, 27 Mar 2026 14:17:08 +0100 Message-ID: <20260327132234.123474-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774617707676 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G3ALHSI6RJYCPGSH3LFZLUNCP72K572M X-Message-ID-Hash: G3ALHSI6RJYCPGSH3LFZLUNCP72K572M X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The --cuddled-else flag is equivalent to --cuddled-blocks, but might wrongly suggest that it only applies to else (and elsif). While those are the most relevant ones for the Proxmox codebases, there are a few other ones (see 'man perltidy'). Using --cuddled-blocks also better suggests that the --cuddled-block-list option is a modifier that only takes effect when --cuddled-blocks itself is present. Signed-off-by: Fiona Ebner --- src/perltidyrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/perltidyrc b/src/perltidyrc index 300cf81..4299f29 100644 --- a/src/perltidyrc +++ b/src/perltidyrc @@ -70,7 +70,7 @@ --maximum-consecutive-blank-lines=1 # hard-code the default # Control structure formatting ---cuddled-else # avoid extra line for else +--cuddled-blocks # avoid extra line for else, elsif, ... --cuddled-block-list=sort,map,grep # also cuddle sort, map and grep over standard else/elsif/... --keyword-group-blanks-inside -- 2.47.3