From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C02A81FF140 for ; Fri, 27 Mar 2026 11:38:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D2CC44A3C; Fri, 27 Mar 2026 11:38:45 +0100 (CET) From: David Riley To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid Date: Fri, 27 Mar 2026 11:38:00 +0100 Message-ID: <20260327103801.104735-1-d.riley@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774607841022 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.826 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QZTNVHSQ5DUGDTO6RVKD2UDMR3OHFCOK X-Message-ID-Hash: QZTNVHSQ5DUGDTO6RVKD2UDMR3OHFCOK X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Riley X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This v2 implements the suggested stop-gap solution for filtering the virtual guest selection in the backup job edit window. Differences from v1: - Drop the complex collapsible filter panel (tags, pools, HA State) This avoids the UX trap of users thinking the filters apply dynamically at job runtime (deferring that feature for a proper implementation of #4186 [0]). - Add search text-field in the grid toolbar to filter by Name or VMID. - Add a "Review" toggle checkbox in the bottom toolbar that limits the grid view to only currently selected guests. - Add a "Selected (X)" counter in the bottom toolbar for immediate visual feedback. - Override the `getValue` collection logic to gather data directly from the SelectionModel, ensuring virtual guests hidden by the Search filter are still correctly submitted. Thanks for testing and reviewing my last patch. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=4186 David Riley (1): fix: #4490 ui: backup job window: add search for virtual guest grid www/manager6/dc/Backup.js | 167 +++++++++++++++++++++++++++++++++++++- 1 file changed, 166 insertions(+), 1 deletion(-) -- 2.47.3