From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5394C1FF13F for ; Thu, 26 Mar 2026 12:33:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A392FF94E; Thu, 26 Mar 2026 12:33:31 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 2/2] backup: log backup start via QMP command to avoid confusion about freeze/thaw Date: Thu, 26 Mar 2026 12:31:42 +0100 Message-ID: <20260326113251.68540-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260326113251.68540-1-f.ebner@proxmox.com> References: <20260326113251.68540-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774524726127 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 67HHAUVOTKWGKZF46VXMQNRCFI3ZLVQC X-Message-ID-Hash: 67HHAUVOTKWGKZF46VXMQNRCFI3ZLVQC X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Curently, a backup task log looks like: > INFO: issuing guest-agent 'fs-freeze' command > INFO: issuing guest-agent 'fs-thaw' command > INFO: started backup task 'beebb719-bdb8-4de8-9d34-5cbf182cea3e' or in case of a failure during backup start: > INFO: issuing guest-agent 'fs-freeze' command > INFO: issuing guest-agent 'fs-thaw' command > ERROR: VM 100 qmp command 'backup' failed - Both might suggest that the thaw operation and starting the backup happen in the wrong order, which can lead to confusion. Add a log line when issuing the 'backup' QMP command to clarify that this is not the case. After the patch, the task logs look like: > INFO: issuing guest-agent 'fs-freeze' command > INFO: starting backup via QMP command > INFO: issuing guest-agent 'fs-thaw' command > INFO: started backup task 'e4e961c1-661b-4971-aefb-6715fd6a0d70' or in case of a failure during backup start: > INFO: issuing guest-agent 'fs-freeze' command > INFO: starting backup via QMP command > INFO: issuing guest-agent 'fs-thaw' command > ERROR: VM 100 qmp command 'backup' failed - In case of provider-based backups, there already is a log-message between freeze and thaw: > INFO: issuing guest-agent 'fs-freeze' command > INFO: setting up snapshot-access for backup > INFO: issuing guest-agent 'fs-thaw' command Signed-off-by: Fiona Ebner --- src/PVE/VZDump/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm index 2d55fbfa..cdf20219 100644 --- a/src/PVE/VZDump/QemuServer.pm +++ b/src/PVE/VZDump/QemuServer.pm @@ -841,6 +841,7 @@ sub archive_pbs { $params->{timeout} = 125; # give some time to connect to the backup server + $self->loginfo("starting backup via QMP command"); my $res = eval { mon_cmd($vmid, "backup", %$params) }; my $qmperr = $@; $backup_job_uuid = $res->{UUID} if $res; @@ -1024,6 +1025,7 @@ sub archive_vma { my $fs_frozen = $self->qga_fs_freeze($task, $vmid); + $self->loginfo("starting backup via QMP command"); eval { $qmpclient->queue_execute(30) }; my $qmperr = $@; -- 2.47.3