From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 29FB71FF13B for ; Wed, 25 Mar 2026 22:34:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 26A0635EB8; Wed, 25 Mar 2026 22:34:56 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs Date: Wed, 25 Mar 2026 22:28:05 +0100 Message-ID: <20260325213415.3861690-5-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325213415.3861690-1-t.lamprecht@proxmox.com> References: <20260325213415.3861690-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774474412661 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S5FI7IQFKQTFEZ25CBOWD6WMZQS2TVRE X-Message-ID-Hash: S5FI7IQFKQTFEZ25CBOWD6WMZQS2TVRE X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: These settings are already in the (QEMU guest) agent property, and we do not use the guest- prefix for any of the existing properties (fstrim or freeze-fs-on-backup), and moving freeze-fs-on-backup to a generic variant is less confusing if one just drops the "-on-backup" part, i.e. no point in inventing a new name schema just for the sake of it. We already rolled this the guest-fsfreeze name to pve-test, so lets add an alias, but as we do not provide API stability guarantees for test packages this is really just for convenience for anybody that tested this, I'm more than fine with dropping such a (never stable) released key again on a major release with the respective upgrade check in our pveXtoY tool. Signed-off-by: Thomas Lamprecht --- src/PVE/QemuServer/Agent.pm | 9 +++++++-- src/test/cfg2cmd/qga-fs-freeze.conf | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer/Agent.pm b/src/PVE/QemuServer/Agent.pm index b0abd7c0..23dbb3ff 100644 --- a/src/PVE/QemuServer/Agent.pm +++ b/src/PVE/QemuServer/Agent.pm @@ -38,9 +38,14 @@ our $agent_fmt = { 'freeze-fs-on-backup' => { type => 'boolean', optional => 1, - alias => 'guest-fsfreeze', # keep for old backup restore compatibility + alias => 'freeze-fs', # keep for old backup restore compatibility }, 'guest-fsfreeze' => { + type => 'boolean', + optional => 1, + alias => 'freeze-fs', # TODO: was only on test repo, drop with PVE 10. + }, + 'freeze-fs' => { description => "Freeze guest filesystems through QGA for consistent disk state on" . " operations such as snapshots, backups, replications and clones.", verbose_description => @@ -211,7 +216,7 @@ sub should_fs_freeze { my $agent = parse_guest_agent($conf); return 0 if !$agent->{enabled}; - return $agent->{'guest-fsfreeze'} // 1; + return $agent->{'freeze-fs'} // 1; } =head3 guest_fsfreeze diff --git a/src/test/cfg2cmd/qga-fs-freeze.conf b/src/test/cfg2cmd/qga-fs-freeze.conf index c32e143e..809b7d43 100644 --- a/src/test/cfg2cmd/qga-fs-freeze.conf +++ b/src/test/cfg2cmd/qga-fs-freeze.conf @@ -1,2 +1,2 @@ # TEST: Ensure agent sub-properties do not affect the QEMU command line. -agent: 1,guest-fsfreeze=1 +agent: 1,freeze-fs=1 -- 2.47.3