From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 129681FF13B for ; Wed, 25 Mar 2026 10:44:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B660210520; Wed, 25 Mar 2026 10:42:47 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs 2/3] pve-rs: sdn: add prefix lists module Date: Wed, 25 Mar 2026 10:41:24 +0100 Message-ID: <20260325094142.174364-14-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325094142.174364-1-s.hanreich@proxmox.com> References: <20260325094142.174364-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774431664020 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.281 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SIQJX5ON4ISSE4HVWJHDE7LXLEOMSFC2 X-Message-ID-Hash: SIQJX5ON4ISSE4HVWJHDE7LXLEOMSFC2 X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Exposes the functionality from ve-config to Perl by providing helpers for instantiating the Rust configuration from Perl. The module also contains the implementation for the CRUD API methods, which will be used for implementing the API methods in pve-network. Signed-off-by: Stefan Hanreich --- pve-rs/Makefile | 1 + pve-rs/src/bindings/sdn/mod.rs | 1 + pve-rs/src/bindings/sdn/prefix_lists.rs | 199 ++++++++++++++++++++++++ 3 files changed, 201 insertions(+) create mode 100644 pve-rs/src/bindings/sdn/prefix_lists.rs diff --git a/pve-rs/Makefile b/pve-rs/Makefile index d662b00..e7dfe2e 100644 --- a/pve-rs/Makefile +++ b/pve-rs/Makefile @@ -31,6 +31,7 @@ PERLMOD_PACKAGES := \ PVE::RS::OpenId \ PVE::RS::ResourceScheduling::Static \ PVE::RS::SDN::Fabrics \ + PVE::RS::SDN::PrefixLists \ PVE::RS::SDN::RouteMaps \ PVE::RS::SDN \ PVE::RS::TFA diff --git a/pve-rs/src/bindings/sdn/mod.rs b/pve-rs/src/bindings/sdn/mod.rs index c571d28..9bddf1c 100644 --- a/pve-rs/src/bindings/sdn/mod.rs +++ b/pve-rs/src/bindings/sdn/mod.rs @@ -1,4 +1,5 @@ pub(crate) mod fabrics; +pub(crate) mod prefix_lists; pub(crate) mod route_maps; #[perlmod::package(name = "PVE::RS::SDN", lib = "pve_rs")] diff --git a/pve-rs/src/bindings/sdn/prefix_lists.rs b/pve-rs/src/bindings/sdn/prefix_lists.rs new file mode 100644 index 0000000..52d30af --- /dev/null +++ b/pve-rs/src/bindings/sdn/prefix_lists.rs @@ -0,0 +1,199 @@ +#[perlmod::package(name = "PVE::RS::SDN::PrefixLists", lib = "pve_rs")] +pub mod pve_rs_sdn_prefix_lists { + //! The `PVE::RS::SDN::PrefixLists` package. + //! + //! This provides the configuration for the SDN fabrics, as well as helper methods for reading + //! / writing the configuration, as well as for generating ifupdown2 and FRR configuration. + + use core::clone::Clone; + use std::collections::HashMap; + use std::ops::Deref; + use std::sync::Mutex; + + use anyhow::{anyhow, Error}; + use openssl::hash::{hash, MessageDigest}; + use serde::{Deserialize, Serialize}; + + use perlmod::Value; + use proxmox_section_config::typed::{ApiSectionDataEntry, SectionConfigData}; + use proxmox_ve_config::sdn::prefix_list::api::{ + PrefixList as ApiPrefixList, PrefixListDeletableProperties, PrefixListUpdater, + }; + use proxmox_ve_config::sdn::prefix_list::{PrefixList as ConfigPrefixList, PrefixListId}; + + /// A SDN PrefixList config instance. + #[derive(Serialize, Deserialize)] + pub struct PerlPrefixListConfig { + /// The fabric config instance + pub prefix_lists: Mutex>, + } + + perlmod::declare_magic!(Box : &PerlPrefixListConfig as "PVE::RS::SDN::PrefixLists::Config"); + + /// Class method: Parse the raw configuration from `/etc/pve/sdn/prefix-lists.cfg`. + #[export] + pub fn config(#[raw] class: Value, raw_config: &[u8]) -> Result { + let raw_config = std::str::from_utf8(raw_config)?; + let config = ConfigPrefixList::parse_section_config("prefix-lists.cfg", raw_config)?; + + Ok( + perlmod::instantiate_magic!(&class, MAGIC => Box::new(PerlPrefixListConfig { + prefix_lists: Mutex::new(config.deref().clone()), + })), + ) + } + + /// Class method: Parse the configuration from `/etc/pve/sdn/.running_config`. + #[export] + pub fn running_config( + #[raw] class: Value, + prefix_lists: HashMap, + ) -> Result { + let prefix_lists: SectionConfigData = + SectionConfigData::from_iter(prefix_lists); + + Ok( + perlmod::instantiate_magic!(&class, MAGIC => Box::new(PerlPrefixListConfig { + prefix_lists: Mutex::new(prefix_lists.deref().clone()), + })), + ) + } + + /// Used for writing the running configuration. + #[export] + pub fn to_sections( + #[try_from_ref] this: &PerlPrefixListConfig, + ) -> Result, Error> { + let config = this.prefix_lists.lock().unwrap(); + Ok(config.deref().clone()) + } + + /// Method: Convert the configuration into the section config string. + /// + /// Used for writing `/etc/pve/sdn/prefix-lists.cfg` + #[export] + pub fn to_raw(#[try_from_ref] this: &PerlPrefixListConfig) -> Result { + let config = this.prefix_lists.lock().unwrap(); + + let prefix_lists: SectionConfigData = + SectionConfigData::from_iter(config.deref().clone()); + + ConfigPrefixList::write_section_config("prefix-lists.cfg", &prefix_lists) + } + + /// Method: Generate a digest for the whole configuration + #[export] + pub fn digest(#[try_from_ref] this: &PerlPrefixListConfig) -> Result { + let config = to_raw(this)?; + let hash = hash(MessageDigest::sha256(), config.as_bytes())?; + + Ok(hex::encode(hash)) + } + + /// Returns a list of all PrefixLists + #[export] + pub fn list( + #[try_from_ref] this: &PerlPrefixListConfig, + ) -> Result, Error> { + Ok(this + .prefix_lists + .lock() + .unwrap() + .iter() + .map(|(id, prefix_list)| { + let ConfigPrefixList::PrefixList(prefix_list) = prefix_list; + (id.clone(), prefix_list.clone()) + }) + .collect()) + } + + /// Create a new PrefixList. + #[export] + pub fn create( + #[try_from_ref] this: &PerlPrefixListConfig, + prefix_list: ApiPrefixList, + ) -> Result<(), Error> { + let mut prefix_lists = this.prefix_lists.lock().unwrap(); + + if prefix_lists.get(prefix_list.id().as_str()).is_some() { + anyhow::bail!( + "prefix list already exists in configuration: {}", + prefix_list.id() + ); + } + + prefix_lists.insert( + prefix_list.id().as_str().to_string(), + ConfigPrefixList::PrefixList(prefix_list), + ); + + Ok(()) + } + + /// Get a specific PrefixList. + #[export] + pub fn get( + #[try_from_ref] this: &PerlPrefixListConfig, + id: PrefixListId, + ) -> Result, Error> { + Ok(this + .prefix_lists + .lock() + .unwrap() + .iter() + .find(|(_id, prefix_list)| { + let ConfigPrefixList::PrefixList(prefix_list) = prefix_list; + prefix_list.id() == &id + }) + .map(|(_id, prefix_list)| { + let ConfigPrefixList::PrefixList(prefix_list) = prefix_list; + prefix_list.clone() + })) + } + + /// Update a PrefixList. + #[export] + pub fn update( + #[try_from_ref] this: &PerlPrefixListConfig, + id: PrefixListId, + updater: PrefixListUpdater, + delete: Option>, + ) -> Result<(), Error> { + let mut prefix_lists = this.prefix_lists.lock().unwrap(); + + let ConfigPrefixList::PrefixList(prefix_list) = prefix_lists + .get_mut(id.as_str()) + .ok_or_else(|| anyhow!("Could not find prefix list with id: {}", id))?; + + let PrefixListUpdater { entries } = updater; + + if let Some(entries) = entries { + prefix_list.entries = entries; + } + + for deletable_property in delete.unwrap_or_default() { + match deletable_property { + PrefixListDeletableProperties::Entries => { + prefix_list.entries = Vec::new(); + } + } + } + + Ok(()) + } + + /// Delete a PrefixList. + #[export] + pub fn delete( + #[try_from_ref] this: &PerlPrefixListConfig, + id: PrefixListId, + ) -> Result<(), Error> { + this.prefix_lists + .lock() + .unwrap() + .remove(&id.to_string()) + .ok_or_else(|| anyhow!("could not find route map entry with id: {id}"))?; + + Ok(()) + } +} -- 2.47.3