From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BB7BD1FF144 for ; Tue, 24 Mar 2026 19:32:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB7BB1A8C2; Tue, 24 Mar 2026 19:31:29 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v2 24/40] sim: hardware: handle dynamic service stats Date: Tue, 24 Mar 2026 19:30:08 +0100 Message-ID: <20260324183029.1274972-25-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324183029.1274972-1-d.kral@proxmox.com> References: <20260324183029.1274972-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774376989193 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 55KKEGXLXXUFGZD4CP2BEWECGO4RDLXA X-Message-ID-Hash: 55KKEGXLXXUFGZD4CP2BEWECGO4RDLXA X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Dominik Rusovac This adds functionality to simulate dynamic stats of a service, that is, cpu load (cores) and memory usage (MiB). Analogous to static service stats, within tests, dynamic service stats can be specified in file dynamic_service_stats. Signed-off-by: Dominik Rusovac Signed-off-by: Daniel Kral --- changes v1 -> v2: - new! wrt v1: - do not skip falsy stats in set_dynamic_service_stats src/PVE/HA/Sim/Hardware.pm | 52 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/src/PVE/HA/Sim/Hardware.pm b/src/PVE/HA/Sim/Hardware.pm index c167abd7..cb4a1504 100644 --- a/src/PVE/HA/Sim/Hardware.pm +++ b/src/PVE/HA/Sim/Hardware.pm @@ -21,8 +21,11 @@ use PVE::HA::Groups; my $watchdog_timeout = 60; +my $default_service_cpu = 2.0; my $default_service_maxcpu = 4.0; +my $default_service_mem = 2048 * 1024**2; my $default_service_maxmem = 4096 * 1024**2; + my $default_node_maxcpu = 24.0; my $default_node_maxmem = 131072 * 1024**2; @@ -213,6 +216,25 @@ sub set_static_service_stats { $self->write_static_service_stats($stats); } +sub set_dynamic_service_stats { + my ($self, $sid, $new_stats) = @_; + + my $conf = $self->read_service_config(); + die "no such service '$sid'" if !$conf->{$sid}; + + my $stats = $self->read_dynamic_service_stats(); + + if (defined(my $memory = $new_stats->{mem})) { + $stats->{$sid}->{mem} = $memory; + } + + if (defined(my $cpu = $new_stats->{cpu})) { + $stats->{$sid}->{cpu} = $cpu; + } + + $self->write_dynamic_service_stats($stats); +} + sub add_service { my ($self, $sid, $opts, $running) = @_; @@ -438,6 +460,16 @@ sub read_static_service_stats { return $stats; } +sub read_dynamic_service_stats { + my ($self) = @_; + + my $filename = "$self->{statusdir}/dynamic_service_stats"; + my $stats = eval { PVE::HA::Tools::read_json_from_file($filename) }; + $self->log('error', "loading dynamic service stats failed - $@") if $@; + + return $stats; +} + sub write_static_service_stats { my ($self, $stats) = @_; @@ -446,6 +478,14 @@ sub write_static_service_stats { $self->log('error', "writing static service stats failed - $@") if $@; } +sub write_dynamic_service_stats { + my ($self, $stats) = @_; + + my $filename = "$self->{statusdir}/dynamic_service_stats"; + eval { PVE::HA::Tools::write_json_to_file($filename, $stats) }; + $self->log('error', "writing dynamic service stats failed - $@") if $@; +} + sub new { my ($this, $testdir) = @_; @@ -536,6 +576,18 @@ sub new { $self->write_static_service_stats($stats); } + if (-f "$testdir/dynamic_service_stats") { + copy("$testdir/dynamic_service_stats", "$statusdir/dynamic_service_stats"); + } else { + my $services = $self->read_static_service_stats(); + my $stats = { + map { $_ => { cpu => $default_service_cpu, mem => $default_service_mem } } + keys %$services + }; + + $self->write_dynamic_service_stats($stats); + } + my $cstatus = $self->read_hardware_status_nolock(); foreach my $node (sort keys %$cstatus) { -- 2.47.3