From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 83D791FF144 for ; Tue, 24 Mar 2026 14:53:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B67412B40; Tue, 24 Mar 2026 14:53:34 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 3/8] backup: freeze: fix check if agent is enabled Date: Tue, 24 Mar 2026 14:50:43 +0100 Message-ID: <20260324135325.120749-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260324135325.120749-1-f.ebner@proxmox.com> References: <20260324135325.120749-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774360362264 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FS7AJQB4W5WEJ3OSOUHN2X64B4RHUPIP X-Message-ID-Hash: FS7AJQB4W5WEJ3OSOUHN2X64B4RHUPIP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Just checking whether the configuration is present does not mean that the guest agent is enabled. Explicitly check the 'enabled' property. In case of clone/import and snapshot, this is already done. This avoids a log message about the agent not running, since there is no device added to the QEMU commandline for communicating with the agent if disabled. Signed-off-by: Fiona Ebner --- src/PVE/VZDump/QemuServer.pm | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/PVE/VZDump/QemuServer.pm b/src/PVE/VZDump/QemuServer.pm index 55fb6dc4..0681661d 100644 --- a/src/PVE/VZDump/QemuServer.pm +++ b/src/PVE/VZDump/QemuServer.pm @@ -1092,19 +1092,24 @@ sub _get_task_devlist { sub qga_fs_freeze { my ($self, $task, $vmid) = @_; return - if !$self->{vmlist}->{$vmid}->{agent} - || $task->{mode} eq 'stop' + if $task->{mode} eq 'stop' || !$self->{vm_was_running} || $self->{vm_was_paused}; + my $conf = $self->{vmlist}->{$vmid}; + + if (!PVE::QemuServer::Agent::get_qga_key($conf, 'enabled')) { + $self->loginfo("skipping guest-agent 'fs-freeze', agent not configured in VM options"); + return; + } + if (!PVE::QemuServer::Agent::qga_check_running($vmid, 1)) { $self->loginfo("skipping guest-agent 'fs-freeze', agent configured but not running?"); return; } - my $freeze = PVE::QemuServer::Agent::get_qga_key($self->{vmlist}->{$vmid}, 'guest-fsfreeze'); - $freeze //= - PVE::QemuServer::Agent::get_qga_key($self->{vmlist}->{$vmid}, 'freeze-fs-on-backup'); + my $freeze = PVE::QemuServer::Agent::get_qga_key($conf, 'guest-fsfreeze'); + $freeze //= PVE::QemuServer::Agent::get_qga_key($conf, 'freeze-fs-on-backup'); $freeze //= 1; if (!$freeze) { -- 2.47.3