From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A7F381FF144 for ; Tue, 24 Mar 2026 13:49:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5571DF6DE; Tue, 24 Mar 2026 13:50:00 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 0/2] fix param check for rules updates and Date: Tue, 24 Mar 2026 13:49:19 +0100 Message-ID: <20260324124921.148515-1-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774356548016 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.087 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GVKAK5HOIV56XILPJCR6SNKTGHAY6J5B X-Message-ID-Hash: GVKAK5HOIV56XILPJCR6SNKTGHAY6J5B X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This series fixes the PUT API endpoint for updating a HA rule. Previously, it would fail if the resources parameter was not set at all as part of the request, even though the param is optional As part of an E2E test run, the error showed up as 500 update HA rules failed: Can't use an undefined value as a HASH reference at /usr/share/perl5/PVE/API2/HA/Rules.pm line 48. In addition, 2/2 fixes wrong formatting introduced by a recent commit. pve-ha-manager: Michael Köppl (2): api: assert validity of resources param only if defined format code with perltidy src/PVE/API2/HA/Rules.pm | 2 +- src/PVE/HA/Usage/Static.pm | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) Summary over all repositories: 2 files changed, 5 insertions(+), 3 deletions(-) -- Generated by murpp 0.11.0