From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3B99C1FF13C for ; Thu, 19 Mar 2026 15:37:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EABD81F0E; Thu, 19 Mar 2026 15:37:38 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup 1/5] tools: add helper to run fstrim command on path or mountpoint Date: Thu, 19 Mar 2026 15:36:45 +0100 Message-ID: <20260319143649.681937-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260319143649.681937-1-c.ebner@proxmox.com> References: <20260319143649.681937-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773930980283 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PI6VRL2CSM2WS3CCSZFA57CJOY24LC7U X-Message-ID-Hash: PI6VRL2CSM2WS3CCSZFA57CJOY24LC7U X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Runs the fstrim on the filesystem mounted at given mountpoint or path on the filesystem, allowing to discard unused blocks on the backing disk. By invoking with `verbose` flag enabled, statistics are gathered in the output to show on result. Setting `quiet-unsupported` allows to run the command without error also on filesystems without support [0]. With the intention to run this as scheduled job on a datastore's backing filesystem. [0] https://www.man7.org/linux/man-pages/man8/fstrim.8.html Signed-off-by: Christian Ebner --- src/tools/disks/mod.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs index a86cbdf79..a5cb091a7 100644 --- a/src/tools/disks/mod.rs +++ b/src/tools/disks/mod.rs @@ -1392,3 +1392,13 @@ pub fn unmount_by_mountpoint(path: &Path) -> Result<(), Error> { proxmox_sys::command::run_command(command, None)?; Ok(()) } + +/// Run fstrim on mounted filesystem backing given path. +pub fn fstrim(path: &Path) -> Result { + let mut command = std::process::Command::new("fstrim"); + command.arg(path); + command.arg("--verbose"); + command.arg("--quiet-unsupported"); + + proxmox_sys::command::run_command(command, Some(|exit_code| exit_code == 0)) +} -- 2.47.3