From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9C4E01FF13C for ; Thu, 19 Mar 2026 12:03:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF0521B385; Thu, 19 Mar 2026 12:03:25 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 0/3] fix #7400: improve handling of corrupted job statefiles Date: Thu, 19 Mar 2026 12:03:15 +0100 Message-ID: <20260319110318.70346-1-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773918157577 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.985 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IV6BKO7JCOH5JI6XFR4V6RDDIJFT7E2P X-Message-ID-Hash: IV6BKO7JCOH5JI6XFR4V6RDDIJFT7E2P X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This patch series fixes a problem where an empty or corrupted job state file (due to I/O error, abrupt shutdown, ...) would cause API endpoints for listing jobs to return an error, breaking the web UI for users because they could not view any of their configured jobs of that type. It would also cause proxmox-backup-proxy to indefinitely skip the jobs until a user manually triggered it to rewrite the statefile. 1/3 is a preparatory patch that centralizes job statefile loading in compute_schedule_status instead of having every handler function open the statefile, handle potential errors and then passing the JobState to compute_schedule_status. 2/3 fixes the API layer by catching the load error, logging an error message, and returning a default JobScheduleStatus. This ensure the API returns the job list, showing the affected job without its last run status. 3/3 updates the scheduler loop inside the proxy to match the behavior of a a newly created job, triggering the job at its next internal (which then rewrites the statefile). changes since v1: - added preparatory patch 1/3, centralizing the statefile loading before adapting the handling of the error case in that centralized place (compute_schedule_status). Thanks, Christian for the suggestion! - adapted the error message if job statefile loading fails to make clear that the default status will be returned as a fallback proxmox-backup: Michael Köppl (3): api: move statefile loading into compute_schedule_status fix #7400: api: gracefully handle corrupted job statefiles fix #7400: proxy: self-heal corrupted job statefiles src/api2/admin/datastore.rs | 13 +++---------- src/api2/admin/prune.rs | 9 +++------ src/api2/admin/sync.rs | 9 +++------ src/api2/admin/verify.rs | 9 +++------ src/api2/tape/backup.rs | 9 +++------ src/bin/proxmox-backup-proxy.rs | 2 +- src/server/jobstate.rs | 17 +++++++++++++++-- 7 files changed, 31 insertions(+), 37 deletions(-) Summary over all repositories: 7 files changed, 31 insertions(+), 37 deletions(-) -- Generated by murpp 0.10.0