From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8AAAA1FF138 for ; Wed, 18 Mar 2026 12:11:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 297EA33D13; Wed, 18 Mar 2026 12:11:21 +0100 (CET) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v4 1/2] pmxcfs: remove world-readable permissions from backups Date: Wed, 18 Mar 2026 12:11:10 +0100 Message-ID: <20260318111111.114933-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260318111111.114933-1-s.sterz@proxmox.com> References: <20260318111111.114933-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773832230880 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.944 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LT5XJ6BHFF7WJWVTAQRQN5LMXRBJVOMD X-Message-ID-Hash: LT5XJ6BHFF7WJWVTAQRQN5LMXRBJVOMD X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this could lead to information disclosure of data that is private within pmxcfs. currently the impact is low as a backup is only triggered before joining a new cluster. however, if we trigger more backups going forward, this could leak sensitive information. Signed-off-by: Shannon Sterz --- the version in the postinst hook should probably be adapted when pve-cluster is bumped. debian/pve-cluster.dirs | 1 + debian/pve-cluster.postinst | 8 ++++++++ src/PVE/Cluster.pm | 5 +++-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/debian/pve-cluster.dirs b/debian/pve-cluster.dirs index a07aa4e..df4a258 100644 --- a/debian/pve-cluster.dirs +++ b/debian/pve-cluster.dirs @@ -1,2 +1,3 @@ /usr/bin /var/lib/pve-cluster +/var/lib/pve-cluster/backup diff --git a/debian/pve-cluster.postinst b/debian/pve-cluster.postinst index 34bf0e1..048199e 100644 --- a/debian/pve-cluster.postinst +++ b/debian/pve-cluster.postinst @@ -11,12 +11,20 @@ remove_fabrics_directory() { fi } +update_permissions() { + chmod 0600 /var/lib/pve-cluster/backup; +} + case "$1" in configure) # TODO: remove with PVE 10+ if dpkg --compare-versions "$2" 'lt' '9.0.1'; then remove_fabrics_directory fi + + if dpkg --compare-versions "$2" 'lt' '9.1.1'; then + update_permissions + fi ;; esac diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index bdb465f..e96a7fe 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -9,7 +9,7 @@ use File::Path qw(make_path); use JSON; use List::Util; use Net::SSLeay; -use POSIX qw(ENOENT); +use POSIX qw(ENOENT EEXIST); use Socket; use Storable qw(dclone); use Time::HiRes qw(usleep); @@ -892,7 +892,8 @@ sub complete_migration_target { # NOTE: filesystem must be offline here, no DB changes allowed sub cfs_backup_database { - mkdir $dbbackupdir; + mkdir $dbbackupdir or $!{EEXIST} or die "failed to create backup dir - $!\n"; + chmod 0600, $dbbackupdir or die "failed to change mode for backup dir - $!\n"; my $ctime = time(); my $backup_fn = "$dbbackupdir/config-$ctime.sql.gz"; -- 2.47.3