From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 74D731FF138 for ; Wed, 18 Mar 2026 12:11:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E18CB33B9C; Wed, 18 Mar 2026 12:11:18 +0100 (CET) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v4 0/2] pmxcfs fix backup directory permissions Date: Wed, 18 Mar 2026 12:11:09 +0100 Message-ID: <20260318111111.114933-1-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773832230805 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.946 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DQGSLJRILJIV7IPKHETWSXPSQANSWFIY X-Message-ID-Hash: DQGSLJRILJIV7IPKHETWSXPSQANSWFIY X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changelog --------- changes since v3 (thanks @ Thomas Lamprecht): * moved changing the permissions of the backup directory when creating a backup to commit #1 * use in-built `rename` instead of `File::Copy::move` changes since v2 (thanks @ Thomas Lamprecht): * use chmod to always set the MODE of the backup directory before backing up. * rotate the old config.db out of the way of the new one so we can continue a cluster join even if a backup fails. changes since v1 (thanks @ Thomas Lamprecht): * added a patch fixing the mkdir call in `cfs_backup_database` * version guarded the permission fix up in the post install hook * dropped the `-R` flag provided to the `chmod` call in the postinst hook (it did not provide any extra security and made lintian complain) Shannon Sterz (2): pmxcfs: remove world-readable permissions from backups pmxcfs: don't abort join when backup fails and keep old config database debian/pve-cluster.dirs | 1 + debian/pve-cluster.postinst | 8 ++++++++ src/PVE/Cluster.pm | 10 ++++++++-- src/PVE/Cluster/Setup.pm | 5 +++-- 4 files changed, 20 insertions(+), 4 deletions(-) -- 2.47.3