From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 49D3A1FF141 for ; Mon, 16 Mar 2026 17:18:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20DB230F2D; Mon, 16 Mar 2026 17:18:42 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH manager] ui: qga: parse boolean properties to correctly detect 'yes' and 'on' values Date: Mon, 16 Mar 2026 17:17:05 +0100 Message-ID: <20260316161802.189267-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773677845602 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2EHW5RR6BUUO2ZJCMNK5YJF6INH5BQK6 X-Message-ID-Hash: 2EHW5RR6BUUO2ZJCMNK5YJF6INH5BQK6 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Passing a 'yes' or 'on' value along to the checkbox would leave the checkbox disabled. Signed-off-by: Fiona Ebner --- www/manager6/form/AgentFeatureSelector.js | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js index f1e30e21..a484bd99 100644 --- a/www/manager6/form/AgentFeatureSelector.js +++ b/www/manager6/form/AgentFeatureSelector.js @@ -124,21 +124,14 @@ Ext.define('PVE.form.AgentFeatureSelector', { let vm = me.getViewModel(); let res = PVE.Parser.parsePropertyString(values.agent, 'enabled'); + res.enabled = PVE.Parser.parseBoolean(res.enabled, false); + res.fstrim_cloned_disks = PVE.Parser.parseBoolean(res.fstrim_cloned_disks, false); + res['freeze-fs-on-backup'] = PVE.Parser.parseBoolean(res['freeze-fs-on-backup'], true); + res['guest-fsfreeze'] = PVE.Parser.parseBoolean(res['guest-fsfreeze'], true); // We hide the switch for the deprecated freeze-fs-on-backup if the setting was not // explicitly set by the user or if was explicitly enabled. - vm.set( - 'hideFreezeFsOnBackup', - !Ext.isDefined(res['freeze-fs-on-backup']) || - PVE.Parser.parseBoolean(res['freeze-fs-on-backup']), - ); - - if (!Ext.isDefined(res['freeze-fs-on-backup'])) { - res['freeze-fs-on-backup'] = 1; - } - if (!Ext.isDefined(res['guest-fsfreeze'])) { - res['guest-fsfreeze'] = 1; - } + vm.set('hideFreezeFsOnBackup', res['freeze-fs-on-backup']); me.callParent([res]); }, -- 2.47.3